Skip to content

[Improve] Fixed typo in RepVGG.#985

Merged
mzr1996 merged 2 commits intoopen-mmlab:devfrom
techmonsterwang:wang0821
Aug 22, 2022
Merged

[Improve] Fixed typo in RepVGG.#985
mzr1996 merged 2 commits intoopen-mmlab:devfrom
techmonsterwang:wang0821

Conversation

@techmonsterwang
Copy link
Copy Markdown
Collaborator

@techmonsterwang techmonsterwang commented Aug 21, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

fix issue #979

fix a typo in repvgg.py: branch_nrom to branch_norm

@mzr1996 mzr1996 changed the base branch from master to dev August 22, 2022 02:06
@mzr1996 mzr1996 changed the title fixed [Improve] Fixed typo in RepVGG. Aug 22, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2022

Codecov Report

Merging #985 (86ccad3) into dev (71ef7ba) will increase coverage by 0.81%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #985      +/-   ##
==========================================
+ Coverage   84.57%   85.39%   +0.81%     
==========================================
  Files         134      134              
  Lines        8772     8775       +3     
  Branches     1516     1516              
==========================================
+ Hits         7419     7493      +74     
+ Misses       1117     1058      -59     
+ Partials      236      224      -12     
Flag Coverage Δ
unittests 85.33% <100.00%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/repvgg.py 96.84% <100.00%> (ø)
mmcls/models/classifiers/image.py 91.66% <100.00%> (+0.36%) ⬆️
mmcls/core/visualization/image.py 87.17% <0.00%> (+0.97%) ⬆️
mmcls/datasets/builder.py 83.78% <0.00%> (+5.40%) ⬆️
mmcls/models/backbones/convmixer.py 98.36% <0.00%> (+9.83%) ⬆️
mmcls/datasets/custom.py 100.00% <0.00%> (+11.47%) ⬆️
mmcls/models/utils/helpers.py 100.00% <0.00%> (+20.83%) ⬆️
mmcls/utils/setup_env.py 95.45% <0.00%> (+22.72%) ⬆️
mmcls/utils/device.py 100.00% <0.00%> (+27.27%) ⬆️
mmcls/models/backbones/convnext.py 94.78% <0.00%> (+34.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit ec71d07 into open-mmlab:dev Aug 22, 2022
Ezra-Yu pushed a commit to Ezra-Yu/mmclassification that referenced this pull request Sep 6, 2022
* [Improve] Use `forward_dummy` to calculate FLOPS. (open-mmlab#953)

* fixed

Co-authored-by: Ming-Hsuan-Tu <alec.tu@acer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants