Add deprecation message for deploy tools#697
Merged
mzr1996 merged 5 commits intoopen-mmlab:devfrom Feb 23, 2022
Merged
Conversation
Collaborator
Author
|
@lvhan028 Hi, any comment on this PR? |
Codecov Report
@@ Coverage Diff @@
## dev #697 +/- ##
==========================================
+ Coverage 81.78% 85.03% +3.25%
==========================================
Files 118 121 +3
Lines 6820 7393 +573
Branches 1174 1278 +104
==========================================
+ Hits 5578 6287 +709
+ Misses 1082 916 -166
- Partials 160 190 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mzr1996
reviewed
Feb 23, 2022
Co-authored-by: Ma Zerun <mzr1996@163.com>
mzr1996
added a commit
to mzr1996/mmpretrain
that referenced
this pull request
Nov 24, 2022
* add derepcation message for deploy tools * add space * Update tools/deployment/onnx2tensorrt.py Co-authored-by: Ma Zerun <mzr1996@163.com> * remove colorama package * use plaintext to avoid import mmcv Co-authored-by: Ma Zerun <mzr1996@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since MMDeploy has been released, the deployment tools scattered in each OpenMMLab codebase will be deprecated in future.
Modification
Add deprecation message in deployment tools.
Used package colorama to print cross-platform colored text.
BC-breaking (Optional)
None
Use cases (Optional)
And the message would look like it in Ubuntu18.04 terminal:
