Remove opencv-python-headless dependency by albumentations#833
Merged
ly015 merged 1 commit intoopen-mmlab:masterfrom Aug 4, 2021
Merged
Remove opencv-python-headless dependency by albumentations#833ly015 merged 1 commit intoopen-mmlab:masterfrom
ly015 merged 1 commit intoopen-mmlab:masterfrom
Conversation
jin-s13
approved these changes
Aug 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
- Coverage 83.59% 83.58% -0.02%
==========================================
Files 176 176
Lines 14138 14145 +7
Branches 2364 2364
==========================================
+ Hits 11819 11823 +4
- Misses 1712 1714 +2
- Partials 607 608 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
@ly015 this is an upstream issue. Would you like to ask the albu team to change their dependency to avoid such issues? |
Member
Author
They have a future plan to remove the dependency of opencv-python and use opencv-python-headless only by default, according to here. So I guess the current solution is ok if we hope to keep opencv-python as the single default opencv dependency in mmpose? |
Contributor
|
That will also cause trouble. Now I don't think they could come up with good solution :( |
6 tasks
rollingman1
pushed a commit
to rollingman1/mmpose
that referenced
this pull request
Nov 5, 2021
* correct tpn sthv1 testing * Update tpn_tsm_r50_1x1x8_150e_sthv1_rgb.py
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
HAOCHENYE
added a commit
to HAOCHENYE/mmpose
that referenced
this pull request
Jun 27, 2023
* init * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> * update link in the Chinese version * Update docs/en/tutorials/optim_wrapper.md * Apply suggestions from code review * Update docs/en/tutorials/optim_wrapper.md * merge&remove redundant spaces * Update docs/en/tutorials/optim_wrapper.md Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> * update flat_decay_mult * Apply suggestions from code review Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com> Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com> Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, installing
albumentationsby pip hasopencv-python-headlessdependency even ifopencv-pythonhas already been installed. This could cause different opencv versions installed in the environment and lead to unexpected errors.This PR updates the installation of
albumentationsto prevent using a wheel distribution of it withopencv-python-headlessdependency. See its docs for details.