Skip to content

[Fix] Fix module wrappers registry#1204

Merged
ly015 merged 1 commit intoopen-mmlab:masterfrom
ly015:fix-registry
Feb 24, 2022
Merged

[Fix] Fix module wrappers registry#1204
ly015 merged 1 commit intoopen-mmlab:masterfrom
ly015:fix-registry

Conversation

@ly015
Copy link
Copy Markdown
Member

@ly015 ly015 commented Feb 23, 2022

Motivation

Register DistributedDataParallelWrapper in mmpose to a separate registry whose parent is the MODULE_WRAPPERS registry in mmcv. This avoids scope collision with other codebases.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev-0.24@52d51d5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             dev-0.24    #1204   +/-   ##
===========================================
  Coverage            ?   82.49%           
===========================================
  Files               ?      204           
  Lines               ?    16147           
  Branches            ?     2886           
===========================================
  Hits                ?    13321           
  Misses              ?     2096           
  Partials            ?      730
Flag Coverage Δ
unittests 82.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d51d5...d1cbf51. Read the comment docs.

@RunningLeon
Copy link
Copy Markdown

RunningLeon commented Feb 23, 2022

LGTM

@RunningLeon RunningLeon mentioned this pull request Feb 23, 2022
Closed
@ly015 ly015 changed the base branch from dev-0.24 to master February 24, 2022 07:56
@ly015 ly015 merged commit 976847a into open-mmlab:master Feb 24, 2022
@RunningLeon RunningLeon mentioned this pull request Mar 2, 2022
Closed
@wutongshenqiu wutongshenqiu mentioned this pull request Mar 28, 2022
Merged
This was referenced Apr 20, 2022
Closed
Merged
@ly015 ly015 deleted the fix-registry branch December 1, 2022 04:15
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
@ly015
fix module wrappers registry (open-mmlab#1204)
c2165d5
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
@HAOCHENYE
[Fix] Fix ut error in docker (open-mmlab#1204)
04b0ffe
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
@ly015
fix module wrappers registry (open-mmlab#1204)
6a7bb70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jin-s13 jin-s13 jin-s13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ly015 @RunningLeon @jin-s13