[Feature] Support TTA by zytx121 · Pull Request #9452 · open-mmlab/mmdetection

zytx121 · 2022-12-06T12:54:26Z

Motivation

To support Test-Time-Aug (TTA).

Modification

Add DetTTAModel inherited from the BaseTTAModel in MMEngine.
Add --tta option in tools/test.py to enable TTA during the test.

Use cases

To use the default TTA (average the classification scores of images w/ and w/o flip)

 python tools/test.py configs/retinanet/retinanet_r50_fpn_1x_coco.py checkpoints/resnet50_coco.pth --tta

To use your own custom TTA method

Add tta_model and tta_pipeline in your config file:

tta_model = dict(
   type='DetTTAModel',
   tta_cfg=dict(nms=dict(type='nms', iou_threshold=0.5), max_per_img=100))
tta_pipeline = [
       dict(type='LoadImageFromFile', file_client_args=dict(backend='disk')),
       dict(type='TestTimeAug',
            transforms=[
                [dict(type='Resize', scale=(1333, 800), keep_ratio=True),
                 dict(type='Resize', scale=(1333, 600), keep_ratio=True)],
                [dict(type='RandomFlip', prob=1.),
                 dict(type='RandomFlip', prob=0.)],
                [dict(type='LoadAnnotations', with_bbox=True)],
                [dict(type='PackDetInputs',
                      meta_keys=('img_id', 'img_path', 'ori_shape',
                                 'img_shape', 'scale_factor', 'flip',
                                 'flip_direction'))]])
   ]

test with TTA

python tools/test.py configs/retinanet/retinanet_r50_fpn_1x_coco.py checkpoints.pth --tta

Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

tools/test.py

configs/_base_/models/retinanet_r50_fpn.py

mmdet/models/test_time_augs/model_wrapper.py

configs/_base_/models/retinanet_r50_fpn.py

mmdet/models/test_time_augs/det_tta.py

configs/centernet/centernet_r18-dcnv2_8xb16-crop512-140e_coco.py

mmdet/models/test_time_augs/det_tta.py

configs/_base_/models/retinanet_r50_fpn.py

RangiLyu

Remember to update the document of TTA after the usage is confirmed.

hhaAndroid · 2023-01-16T10:58:13Z

@zytx121 Please synchronize the latest code to ensure that ci can pass

configs/_base_/models/retinanet_r50_fpn.py

configs/centernet/centernet_r18-dcnv2_8xb16-crop512-140e_coco.py

tools/test.py

zytx121 · 2023-02-05T13:02:51Z

@zytx121 Please synchronize the latest code to ensure that ci can pass

Done.

configs/_base_/tta/centernet_tta.py

RangiLyu

LGTM. It would be better if you can add a warning in test.py if there is no tta_cfg in the config.

RangiLyu · 2023-02-08T11:35:22Z

Add the use case to docs/en/user_guides/test.md

zytx121 · 2023-02-08T12:24:32Z

Add the use case to docs/en/user_guides/test.md

LGTM. It would be better if you can add a warning in test.py if there is no tta_cfg in the config.

Done.

docs/en/user_guides/test.md

configs/centernet/centernet_tta.py

Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>

…mlab#9452) Co-authored-by: RangiLyu <lyuchqi@gmail.com> Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>

mm-assistant bot assigned hhaAndroid Dec 6, 2022

zytx121 added the WIP Working in progress label Dec 6, 2022

zytx121 requested review from HAOCHENYE and hhaAndroid December 7, 2022 01:49

hhaAndroid reviewed Dec 8, 2022

View reviewed changes

tools/test.py Outdated Show resolved Hide resolved

configs/_base_/models/retinanet_r50_fpn.py Outdated Show resolved Hide resolved

hhaAndroid reviewed Dec 8, 2022

View reviewed changes

mmdet/models/test_time_augs/model_wrapper.py Outdated Show resolved Hide resolved

ZwwWayne requested a review from hhaAndroid December 12, 2022 06:40

hhaAndroid reviewed Dec 12, 2022

View reviewed changes

ZwwWayne added this to the 3.0.0rc6 milestone Dec 19, 2022

HAOCHENYE mentioned this pull request Dec 27, 2022

Make TTAModel compatible with FSDP. open-mmlab/mmengine#611

Merged

zytx121 force-pushed the zhouyue/tta branch from d65f209 to 8ddb245 Compare December 29, 2022 02:21

zytx121 removed the WIP Working in progress label Dec 30, 2022

zytx121 requested review from RangiLyu and hhaAndroid December 30, 2022 03:47

hhaAndroid reviewed Jan 3, 2023

View reviewed changes

configs/centernet/centernet_r18-dcnv2_8xb16-crop512-140e_coco.py Outdated Show resolved Hide resolved

zytx121 force-pushed the zhouyue/tta branch from 989de19 to e8f26a1 Compare January 3, 2023 03:01

RangiLyu reviewed Jan 3, 2023

View reviewed changes

mmdet/models/test_time_augs/det_tta.py Show resolved Hide resolved

RangiLyu reviewed Jan 3, 2023

View reviewed changes

configs/_base_/models/retinanet_r50_fpn.py Outdated Show resolved Hide resolved

RangiLyu reviewed Jan 3, 2023

View reviewed changes

zytx121 force-pushed the zhouyue/tta branch from 2d72cca to 6ee700f Compare January 6, 2023 14:57

zytx121 requested review from RangiLyu and hhaAndroid January 13, 2023 08:38

hhaAndroid reviewed Jan 16, 2023

View reviewed changes

configs/_base_/models/retinanet_r50_fpn.py Outdated Show resolved Hide resolved

configs/centernet/centernet_r18-dcnv2_8xb16-crop512-140e_coco.py Outdated Show resolved Hide resolved

tools/test.py Outdated Show resolved Hide resolved

ZwwWayne requested a review from hhaAndroid February 2, 2023 03:11

zytx121 added 5 commits February 5, 2023 19:14

update

bc399c9

update

30c7af3

add TwoStageTestTimeAugModel

0c7842f

update

4d5dc5d

update

fbce281

zytx121 added 4 commits February 5, 2023 19:14

Update det_tta.py

a296829

update doc

a609618

Update test.md

aaa75b0

update

5425bab

zytx121 force-pushed the zhouyue/tta branch from 810a071 to 5425bab Compare February 5, 2023 12:30

update doc

9322d0a

RangiLyu reviewed Feb 8, 2023

View reviewed changes

configs/_base_/tta/centernet_tta.py Show resolved Hide resolved

move tta config

2a509cc

zytx121 requested a review from RangiLyu February 8, 2023 11:15

RangiLyu previously approved these changes Feb 8, 2023

View reviewed changes

fix

cf4384f

zytx121 dismissed RangiLyu’s stale review via cf4384f February 8, 2023 12:24

ZwwWayne requested a review from RangiLyu February 8, 2023 13:58

RangiLyu reviewed Feb 9, 2023

View reviewed changes

docs/en/user_guides/test.md Outdated Show resolved Hide resolved

Update docs/en/user_guides/test.md

8aa8194

RangiLyu previously approved these changes Feb 9, 2023

View reviewed changes

hhaAndroid previously approved these changes Feb 9, 2023

View reviewed changes

ZwwWayne reviewed Feb 9, 2023

View reviewed changes

docs/en/user_guides/test.md Outdated Show resolved Hide resolved

docs/en/user_guides/test.md Outdated Show resolved Hide resolved

docs/en/user_guides/test.md Outdated Show resolved Hide resolved

ZwwWayne reviewed Feb 9, 2023

View reviewed changes

configs/centernet/centernet_tta.py Show resolved Hide resolved

zytx121 dismissed hhaAndroid’s stale review via 63a68ab February 11, 2023 12:39

Update docs/en/user_guides/test.md

63a68ab

Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>

zytx121 dismissed RangiLyu’s stale review via 63a68ab February 11, 2023 12:39

update

00876dd

zytx121 requested a review from ZwwWayne February 12, 2023 06:13

ZwwWayne merged commit 99e02c7 into open-mmlab:dev-3.x Feb 14, 2023

Xiangxu-0103 mentioned this pull request Mar 23, 2023

[Feature] Support TTA for Segmentor open-mmlab/mmdetection3d#2382

Merged

Conversation

zytx121 commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modification

Use cases

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RangiLyu left a comment

Choose a reason for hiding this comment

Uh oh!

hhaAndroid commented Jan 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zytx121 commented Feb 5, 2023

Uh oh!

Uh oh!

RangiLyu left a comment

Choose a reason for hiding this comment

Uh oh!

RangiLyu commented Feb 8, 2023

Uh oh!

zytx121 commented Feb 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zytx121 commented Dec 6, 2022 •

edited

Loading