[Feature] Support set dataloader args in config and and add function to handle config compatibility by jshilong · Pull Request #7668 · open-mmlab/mmdetection

jshilong · 2022-04-08T06:31:14Z

Describe the feature

Add train_dataloader, val_dataloader, and test_dataloader in the data field of config so that users can specify different arguments for them.
Add cfg_compatibility to handle the compatibility of config

Motivation

Originally, the data field of config only allows the following usage:

data = dict(
    samples_per_gpu=64, workers_per_gpu=4,
    train=dict(type='xxx', ...),
    val=dict(type='xxx', samples_per_gpu=4, ...),
    test=dict(type='xxx', ...),
)

Such a design only allows setting the different batch sizes in Val and test data loader.
Adding train_dataloader, val_dataloader, and test_dataloader in the data field of config allows more flexible usages.
A new example looks like below:

data = dict(
    train=dict(type='xxx', ...),
    val=dict(type='xxx', ...),
    test=dict(type='xxx', ...),
    # Use different batch size during inference.
    train_dataloader=dict(samples_per_gpu=64, workers_per_gpu=4),
    val_dataloader=dict(samples_per_gpu=8, workers_per_gpu=2),
    test_dataloader=dict(samples_per_gpu=8, workers_per_gpu=2),
)

To achieve that, we should:

allow train_dataloader/val_dataloader/test_dataloader to be set in the data filed by modifying train_detector.
deprecate samples_per_gpu in data.val field by raising warnings if it is set
Related resources
See PR open-mmlab/mmpretrain#752.

Midification

modifying train_detector to allow passing args in the loader field to the build_dataloader
Add a cfg_compatibility to handle the compatibility

BC

None

configs/_base_/datasets/coco_detection.py

mmdet/apis/train.py

tools/test.py

codecov · 2022-04-08T09:11:46Z

Codecov Report

Merging #7668 (8bd8b10) into dev (55a6fe1) will increase coverage by 0.17%.
The diff coverage is 69.33%.

@@            Coverage Diff             @@
##              dev    #7668      +/-   ##
==========================================
+ Coverage   64.76%   64.93%   +0.17%     
==========================================
  Files         346      348       +2     
  Lines       28162    28323     +161     
  Branches     4755     4778      +23     
==========================================
+ Hits        18238    18391     +153     
+ Misses       8962     8956       -6     
- Partials      962      976      +14

Flag	Coverage Δ
unittests	`64.90% <69.33%> (+0.16%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmdet/datasets/builder.py	`54.83% <ø> (ø)`
mmdet/apis/train.py	`13.82% <11.11%> (+0.10%)`	⬆️
mmdet/utils/setup_env.py	`92.00% <60.00%> (-8.00%)`	⬇️
mmdet/utils/compat_config.py	`78.33% <78.33%> (ø)`
mmdet/utils/__init__.py	`100.00% <100.00%> (ø)`
mmdet/datasets/dataset_wrappers.py	`80.31% <0.00%> (-2.21%)`	⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py	`72.36% <0.00%> (-1.32%)`	⬇️
mmdet/core/hook/__init__.py	`100.00% <0.00%> (ø)`
mmdet/datasets/pipelines/__init__.py	`100.00% <0.00%> (ø)`
mmdet/core/hook/memory_profiler_hook.py	`95.65% <0.00%> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a6fe1...8bd8b10. Read the comment docs.

tools/test.py

ZwwWayne

Invite @mzr1996 to take a look.

tools/test.py

mmdet/apis/train.py

mmdet/utils/cfg_compatibility.py

tools/test.py

mmdet/utils/cfg_compatibility.py

tests/test_utils/test_compat_conig.py

mmdet/utils/compat_config.py

wlf-darkmatter · 2022-05-05T14:51:25Z

Describe the feature

Add train_dataloader, val_dataloader, and test_dataloader in the data field of config so that users can specify different arguments for them.

Add cfg_compatibility to handle the compatibility of config

Motivation

Originally, the data field of config only allows the following usage:
data = dict(
    samples_per_gpu=64, workers_per_gpu=4,
    train=dict(type='xxx', ...),
    val=dict(type='xxx', samples_per_gpu=4, ...),
    test=dict(type='xxx', ...),
)
Such a design only allows setting the different batch sizes in Val and test data loader. Adding train_dataloader, val_dataloader, and test_dataloader in the data field of config allows more flexible usages. A new example looks like below:
data = dict(
    train=dict(type='xxx', ...),
    val=dict(type='xxx', ...),
    test=dict(type='xxx', ...),
    # Use different batch size during inference.
    train_dataloader=dict(samples_per_gpu=64, workers_per_gpu=4),
    val_dataloader=dict(samples_per_gpu=8, workers_per_gpu=2),
    test_dataloader=dict(samples_per_gpu=8, workers_per_gpu=2),
)
To achieve that, we should:

allow train_dataloader/val_dataloader/test_dataloader to be set in the data filed by modifying train_detector. deprecate samples_per_gpu in data.val field by raising warnings if it is set Related resources See PR open-mmlab/mmclassification#752.

Midification

modifying train_detector to allow passing args in the loader field to the build_dataloader

Add a cfg_compatibility to handle the compatibility

BC

None

It make an error raised when test_dataloader not inside cfg.data that

AttributeError: 'ConfigDict' object has no attribute 'test_dataloader'

it wou better to add an if to tell if the cfg.data get the attribute test_dataloader to avoid error.

…to handle config compatibility (#7668) * add cfg_compatibility and support loader args * resolve comments * add unitest * resolve comments * delete all warning

…to handle config compatibility (open-mmlab#7668) * add cfg_compatibility and support loader args * resolve comments * add unitest * resolve comments * delete all warning

mm-assistant bot assigned BIGWangYuDong Apr 8, 2022

jshilong requested review from BIGWangYuDong and jbwang1997 April 8, 2022 06:35

ZwwWayne reviewed Apr 8, 2022

View reviewed changes

configs/_base_/datasets/coco_detection.py Show resolved Hide resolved

ZwwWayne reviewed Apr 8, 2022

View reviewed changes

mmdet/apis/train.py Show resolved Hide resolved

ZwwWayne reviewed Apr 8, 2022

View reviewed changes

tools/test.py Show resolved Hide resolved

VVsssssk reviewed Apr 8, 2022

View reviewed changes

tools/test.py Outdated Show resolved Hide resolved

ZwwWayne reviewed Apr 11, 2022

View reviewed changes

wutongshenqiu mentioned this pull request Apr 13, 2022

[Enhance] Add extra dataloader settings in configs open-mmlab/mmrazor#141

Merged

jbwang1997 mentioned this pull request Apr 13, 2022

[Feature] Add dataloader arguments in config open-mmlab/mmrotate#215

Merged

jbwang1997 reviewed Apr 13, 2022

View reviewed changes

tools/test.py Outdated Show resolved Hide resolved

gaotongxiao mentioned this pull request Apr 13, 2022

[Enhancement] More customizable fields in dataloaders open-mmlab/mmocr#933

Merged

mzr1996 reviewed Apr 13, 2022

View reviewed changes

mmdet/apis/train.py Show resolved Hide resolved

jshilong force-pushed the loader_args branch from 3011069 to 63664da Compare April 14, 2022 03:55

jshilong changed the title ~~[Feature]Add loader args to config~~ [Feature] Support set dataloader args in config and and add functions to handle config compatibility Apr 14, 2022

jshilong changed the title ~~[Feature] Support set dataloader args in config and and add functions to handle config compatibility~~ [Feature] Support set dataloader args in config and and add function to handle config compatibility Apr 14, 2022

jshilong force-pushed the loader_args branch from 01058be to 3e26931 Compare April 14, 2022 05:43

add cfg_compatibility and support loader args

a1d1346

jshilong force-pushed the loader_args branch from 3e26931 to a1d1346 Compare April 14, 2022 05:46

ZwwWayne reviewed Apr 18, 2022

View reviewed changes

RangiLyu reviewed Apr 18, 2022

View reviewed changes

mmdet/utils/cfg_compatibility.py Outdated Show resolved Hide resolved

RangiLyu reviewed Apr 18, 2022

View reviewed changes

tools/test.py Outdated Show resolved Hide resolved

RangiLyu reviewed Apr 18, 2022

View reviewed changes

mmdet/utils/cfg_compatibility.py Outdated Show resolved Hide resolved

jshilong added 2 commits April 19, 2022 10:36

resolve comments

46fd3c7

add unitest

061f619

VVsssssk reviewed Apr 19, 2022

View reviewed changes

tests/test_utils/test_compat_conig.py Show resolved Hide resolved

BIGWangYuDong mentioned this pull request Apr 19, 2022

[Feature] Support Class Aware Sampler #7436

Merged

ZwwWayne reviewed Apr 19, 2022

View reviewed changes

tests/test_utils/test_compat_conig.py Show resolved Hide resolved

ZwwWayne reviewed Apr 19, 2022

View reviewed changes

tests/test_utils/test_compat_conig.py Show resolved Hide resolved

resolve comments

99cfb36

mzr1996 reviewed Apr 19, 2022

View reviewed changes

mmdet/utils/compat_config.py Show resolved Hide resolved

delete all warning

8bd8b10

ZwwWayne approved these changes Apr 19, 2022

View reviewed changes

ZwwWayne merged commit dc14675 into open-mmlab:dev Apr 20, 2022

VVsssssk mentioned this pull request Apr 20, 2022

[Feature]Add loader args to config open-mmlab/mmdetection3d#1388

Merged

BIGWangYuDong mentioned this pull request Apr 20, 2022

[Enhance] Add extra dataloader settings in configs. open-mmlab/mmfewshot#71

Merged

jbwang1997 mentioned this pull request Apr 28, 2022

[Fix] Fix no attribute 'samples_per_gpu' bug in auto_scale_lr #7862

Merged

Conversation

jshilong commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe the feature

Motivation

Midification

BC

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

ZwwWayne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wlf-darkmatter commented May 5, 2022

Describe the feature

Motivation

Midification

BC

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jshilong commented Apr 8, 2022 •

edited

Loading

codecov bot commented Apr 8, 2022 •

edited

Loading