Skip to content

fix typos in comment#7124

Merged
ZwwWayne merged 1 commit intoopen-mmlab:devfrom
topsy404:branch-l
Feb 8, 2022
Merged

fix typos in comment#7124
ZwwWayne merged 1 commit intoopen-mmlab:devfrom
topsy404:branch-l

Conversation

@topsy404
Copy link
Copy Markdown
Contributor

@topsy404 topsy404 commented Feb 7, 2022

Motivation

fix typos in comment

Modification

Replace bbox B witth bbox 2.
In the previous content, bbox B was not mentioned.
bbox A's assigned_gt_inds will be overwritten to be bbox 2 instead of bbox B.

bbox A's assigned_gt_inds will be overwritten to be bbox 2 instead of bbox B (In the previous content, bbox B was not mentioned).
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 7, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2022

Codecov Report

Merging #7124 (f620d6a) into dev (ff9bc39) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7124      +/-   ##
==========================================
- Coverage   62.35%   62.17%   -0.19%     
==========================================
  Files         327      330       +3     
  Lines       26129    26033      -96     
  Branches     4424     4437      +13     
==========================================
- Hits        16293    16185     -108     
- Misses       8969     8976       +7     
- Partials      867      872       +5     
Flag Coverage Δ
unittests 62.15% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/bbox/assigners/max_iou_assigner.py 72.36% <ø> (-1.32%) ⬇️
mmdet/datasets/pipelines/formating.py 0.00% <0.00%> (-67.77%) ⬇️
mmdet/core/bbox/samplers/random_sampler.py 75.00% <0.00%> (-5.56%) ⬇️
mmdet/utils/misc.py 95.23% <0.00%> (-4.77%) ⬇️
mmdet/models/dense_heads/base_mask_head.py 40.00% <0.00%> (-4.45%) ⬇️
mmdet/models/seg_heads/base_semantic_head.py 34.37% <0.00%> (-3.87%) ⬇️
mmdet/models/roi_heads/base_roi_head.py 76.47% <0.00%> (-3.53%) ⬇️
mmdet/core/bbox/coder/yolo_bbox_coder.py 50.00% <0.00%> (-2.95%) ⬇️
mmdet/models/detectors/base.py 50.78% <0.00%> (-2.56%) ⬇️
...panoptic_fusion_heads/base_panoptic_fusion_head.py 52.63% <0.00%> (-2.37%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9bc39...f620d6a. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 9bf37f5 into open-mmlab:dev Feb 8, 2022
@topsy404 topsy404 deleted the branch-l branch February 8, 2022 02:30
chhluo pushed a commit to chhluo/mmdetection that referenced this pull request Feb 21, 2022
bbox A's assigned_gt_inds will be overwritten to be bbox 2 instead of bbox B (In the previous content, bbox B was not mentioned).
ZwwWayne pushed a commit that referenced this pull request Jul 18, 2022
bbox A's assigned_gt_inds will be overwritten to be bbox 2 instead of bbox B (In the previous content, bbox B was not mentioned).
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
bbox A's assigned_gt_inds will be overwritten to be bbox 2 instead of bbox B (In the previous content, bbox B was not mentioned).
@OpenMMLab-Assistant003
Copy link
Copy Markdown

Hi @topsy404!First of all, we want to express our gratitude for your significant PR in the MMDetection project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @topsy404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants