[Fix] Relax the requirement of PALETTE in dataset wrappers#7085
Merged
ZwwWayne merged 3 commits intoopen-mmlab:devfrom Jan 29, 2022
Merged
[Fix] Relax the requirement of PALETTE in dataset wrappers#7085ZwwWayne merged 3 commits intoopen-mmlab:devfrom
ZwwWayne merged 3 commits intoopen-mmlab:devfrom
Conversation
RangiLyu
approved these changes
Jan 27, 2022
shinya7y
reviewed
Jan 27, 2022
Codecov Report
@@ Coverage Diff @@
## dev #7085 +/- ##
==========================================
- Coverage 62.41% 62.13% -0.29%
==========================================
Files 330 330
Lines 26199 26018 -181
Branches 4436 4436
==========================================
- Hits 16353 16165 -188
- Misses 8976 8979 +3
- Partials 870 874 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hhaAndroid
approved these changes
Jan 28, 2022
ZwwWayne
approved these changes
Jan 29, 2022
chhluo
pushed a commit
to chhluo/mmdetection
that referenced
this pull request
Feb 21, 2022
This was referenced Feb 23, 2022
ZwwWayne
pushed a commit
that referenced
this pull request
Jul 18, 2022
ZwwWayne
pushed a commit
to ZwwWayne/mmdetection
that referenced
this pull request
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The recent new feature #6716 introduced a new assumption on the
PALETTEattribute in all dataset wrappers, which breaks external references to these wrappers without such an attribute in their datasets. This PR turns this requirement optional.Modification
Dataset wrappers take
PALETTEfrom their dataset classes only if available, or None will be used to fill out the attribute otherwise.BC-breaking (Optional)
None