Skip to content

[Fix] Fix bbox clamp in pt1.10#7074

Merged
ZwwWayne merged 1 commit intoopen-mmlab:devfrom
RangiLyu:fix_pt1.10
Jan 26, 2022
Merged

[Fix] Fix bbox clamp in pt1.10#7074
ZwwWayne merged 1 commit intoopen-mmlab:devfrom
RangiLyu:fix_pt1.10

Conversation

@RangiLyu
Copy link
Copy Markdown
Member

@RangiLyu RangiLyu commented Jan 25, 2022

Motivation

FCOS and AutoAssign cannot run with PyTorch 1.10.
Error message:

RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [2, 4, 20, 20]], which is output 0 of ReluBackward0, is at version 1; expected version 0 instead.

After using with torch.autograd.set_detect_anomaly(True): to debug and find out that it was caused by the ReLU in bbox branch.

Modification

Replace F.relu(bbox_pred) with bbox_pred.clamp(min=0)

@RangiLyu RangiLyu added the bug Something isn't working label Jan 25, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #7074 (9ae7878) into dev (4b87ddc) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7074      +/-   ##
==========================================
- Coverage   62.39%   62.38%   -0.01%     
==========================================
  Files         329      329              
  Lines       26176    26175       -1     
  Branches     4432     4432              
==========================================
- Hits        16332    16330       -2     
- Misses       8974     8975       +1     
  Partials      870      870
Flag Coverage Δ
unittests 62.36% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/fcos_head.py 76.12% <0.00%> (-0.16%) ⬇️
mmdet/models/dense_heads/autoassign_head.py 94.02% <100.00%> (ø)
mmdet/core/bbox/samplers/random_sampler.py 75.00% <0.00%> (-5.56%) ⬇️
mmdet/apis/train.py 15.66% <0.00%> (ø)
mmdet/core/bbox/samplers/sampling_result.py 74.60% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b87ddc...9ae7878. Read the comment docs.

@RangiLyu RangiLyu added WIP Working in progress bug Something isn't working and removed bug Something isn't working WIP Working in progress labels Jan 26, 2022
@ZwwWayne ZwwWayne merged commit 25a95d2 into open-mmlab:dev Jan 26, 2022
@ZwwWayne
Copy link
Copy Markdown
Collaborator

ZwwWayne commented Jan 27, 2022

Several things to be done after merging this PR:

  1. Should add comments above the line of code to indicate the reason for the change.
  2. CI of PyTorch 1.10.

@ZwwWayne ZwwWayne mentioned this pull request Jan 27, 2022
Closed
chhluo pushed a commit to chhluo/mmdetection that referenced this pull request Feb 21, 2022
@RangiLyu @chhluo
[Fix] Fix bbox clamp in pt1.10 (open-mmlab#7074)
da4d64d
ZwwWayne pushed a commit that referenced this pull request Jul 18, 2022
@RangiLyu
[Fix] Fix bbox clamp in pt1.10 (#7074)
14cf2e3
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
@RangiLyu @ZwwWayne
[Fix] Fix bbox clamp in pt1.10 (open-mmlab#7074)
be29af0
@RangiLyu RangiLyu deleted the fix_pt1.10 branch December 17, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RangiLyu @ZwwWayne