[Fix] Put the mAP at the front of OrderedDict in VOCDataset#7064
Merged
ZwwWayne merged 1 commit intoopen-mmlab:devfrom Jan 26, 2022
jbwang1997:mAP_order
Merged
[Fix] Put the mAP at the front of OrderedDict in VOCDataset#7064ZwwWayne merged 1 commit intoopen-mmlab:devfrom jbwang1997:mAP_order
mAP at the front of OrderedDict in VOCDataset#7064ZwwWayne merged 1 commit intoopen-mmlab:devfrom
jbwang1997:mAP_order
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7064 +/- ##
=======================================
Coverage 62.38% 62.39%
=======================================
Files 329 329
Lines 26176 26177 +1
Branches 4432 4432
=======================================
+ Hits 16331 16332 +1
- Misses 8975 8976 +1
+ Partials 870 869 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZwwWayne
approved these changes
Jan 26, 2022
chhluo
pushed a commit
to chhluo/mmdetection
that referenced
this pull request
Feb 21, 2022
ZwwWayne
pushed a commit
that referenced
this pull request
Jul 18, 2022
ZwwWayne
pushed a commit
to ZwwWayne/mmdetection
that referenced
this pull request
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
In VOCDdataset, the first item of output is
AP50. When settingsave_bestasautoin evaluation, theEvalHookcan not match a rule forAP50and will raise an error #7061. Thus, I put themAPat the front of OrderedDict in VOCDataset.Modification
Add
eval_results.move_to_end('mAP', last=False)in VOCDataset.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist