Add nms_rotated ort op by zytx121 · Pull Request #312 · open-mmlab/mmdeploy

zytx121 · 2022-04-05T05:04:34Z

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add nms_rotated ort op.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

codecov · 2022-04-06T02:48:39Z

Codecov Report

Merging #312 (3382a44) into master (b9c5487) will decrease coverage by 0.01%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   62.88%   62.86%   -0.02%     
==========================================
  Files         212      213       +1     
  Lines        7172     7187      +15     
  Branches     1108     1109       +1     
==========================================
+ Hits         4510     4518       +8     
- Misses       2339     2346       +7     
  Partials      323      323

Flag	Coverage Δ
unittests	`62.86% <53.33%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmdeploy/mmcv/ops/nms_rotated.py	`50.00% <50.00%> (ø)`
mmdeploy/mmcv/ops/__init__.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c5487...3382a44. Read the comment docs.

csrc/backend_ops/onnxruntime/nms_rotated/nms_rotated.cpp

csrc/backend_ops/onnxruntime/nms_rotated/nms_rotated.h

* add postprocessing_masks gpu version * default device cpu * pre-commit fix Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt>

…es list is passed (open-mmlab#310)

csrc/backend_ops/onnxruntime/nms_rotated/nms_rotated.cpp

* fix formatter * relax GCC version requirement

…nms_rotated

AllentDan

May update the supported ops in onnxruntime doc

grimoire

LGTM

* fix show * lint * remove redundant codes * resolve comment * type hint

* docs(build): add missing build option * docs(build): add onnx install * style(doc): trim whitespace * docs(build): revert install onnx * docs(build): add ncnn LD_LIBRARY_PATH * docs(build): fix path error

* fix wrong input mat type * fix lint

…nms_rotated

irexyc · 2022-04-18T09:03:55Z

LGTM

The base branch was changed.

* fix pose demo and windows build (open-mmlab#307) * init * Update nms_rotated.cpp * add postprocessing_masks gpu version (open-mmlab#276) * add postprocessing_masks gpu version * default device cpu * pre-commit fix Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt> * fixed a bug causes text-recognizer to fail when (non-NULL) empty bboxes list is passed (open-mmlab#310) * [Fix] include missing <type_traits> for formatter.h (open-mmlab#313) * fix formatter * relax GCC version requirement * fix * fix lint * fix lint * [Fix] MMEditing cannot save results when testing (open-mmlab#336) * fix show * lint * remove redundant codes * resolve comment * type hint * docs(build): fix typo (open-mmlab#352) * docs(build): add missing build option * docs(build): add onnx install * style(doc): trim whitespace * docs(build): revert install onnx * docs(build): add ncnn LD_LIBRARY_PATH * docs(build): fix path error * fix openvino export tmp model, add binary flag (open-mmlab#353) * init circleci (open-mmlab#348) * fix wrong input mat type (open-mmlab#362) * fix wrong input mat type * fix lint * fix(docs): remove redundant doc tree (open-mmlab#360) * fix missing ncnn_DIR & InferenceEngine_DIR (open-mmlab#364) * update doc Co-authored-by: Chen Xin <xinchen.tju@gmail.com> Co-authored-by: Shengxi Li <982783556@qq.com> Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt> Co-authored-by: lzhangzz <lzhang329@gmail.com> Co-authored-by: Yifan Zhou <singlezombie@163.com> Co-authored-by: tpoisonooo <khj.application@aliyun.com> Co-authored-by: lvhan028 <lvhan_028@163.com>

* fix cub path * use cmake source dir instead

* fix pose demo and windows build (open-mmlab#307) * init * Update nms_rotated.cpp * add postprocessing_masks gpu version (open-mmlab#276) * add postprocessing_masks gpu version * default device cpu * pre-commit fix Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt> * fixed a bug causes text-recognizer to fail when (non-NULL) empty bboxes list is passed (open-mmlab#310) * [Fix] include missing <type_traits> for formatter.h (open-mmlab#313) * fix formatter * relax GCC version requirement * fix * fix lint * fix lint * [Fix] MMEditing cannot save results when testing (open-mmlab#336) * fix show * lint * remove redundant codes * resolve comment * type hint * docs(build): fix typo (open-mmlab#352) * docs(build): add missing build option * docs(build): add onnx install * style(doc): trim whitespace * docs(build): revert install onnx * docs(build): add ncnn LD_LIBRARY_PATH * docs(build): fix path error * fix openvino export tmp model, add binary flag (open-mmlab#353) * init circleci (open-mmlab#348) * fix wrong input mat type (open-mmlab#362) * fix wrong input mat type * fix lint * fix(docs): remove redundant doc tree (open-mmlab#360) * fix missing ncnn_DIR & InferenceEngine_DIR (open-mmlab#364) * update doc Co-authored-by: Chen Xin <xinchen.tju@gmail.com> Co-authored-by: Shengxi Li <982783556@qq.com> Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt> Co-authored-by: lzhangzz <lzhang329@gmail.com> Co-authored-by: Yifan Zhou <singlezombie@163.com> Co-authored-by: tpoisonooo <khj.application@aliyun.com> Co-authored-by: lvhan028 <lvhan_028@163.com>

irexyc and others added 3 commits April 2, 2022 22:35

fix pose demo and windows build (open-mmlab#307)

7cfe6e6

init

d6dc2a2

Update nms_rotated.cpp

3698d23

lvhan028 requested review from AllentDan, grimoire, irexyc and lzhangzz April 6, 2022 02:34

grimoire reviewed Apr 6, 2022

View reviewed changes

csrc/backend_ops/onnxruntime/nms_rotated/nms_rotated.cpp Outdated Show resolved Hide resolved

AllentDan reviewed Apr 6, 2022

View reviewed changes

csrc/backend_ops/onnxruntime/nms_rotated/nms_rotated.h Outdated Show resolved Hide resolved

xizi and others added 2 commits April 6, 2022 19:45

add postprocessing_masks gpu version (open-mmlab#276)

442e9cd

* add postprocessing_masks gpu version * default device cpu * pre-commit fix Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt>

fixed a bug causes text-recognizer to fail when (non-NULL) empty bbox…

85c46ee

…es list is passed (open-mmlab#310)

lzhangzz reviewed Apr 7, 2022

View reviewed changes

csrc/backend_ops/onnxruntime/nms_rotated/nms_rotated.cpp Show resolved Hide resolved

lzhangzz and others added 5 commits April 11, 2022 20:45

[Fix] include missing <type_traits> for formatter.h (open-mmlab#313)

6e7e219

* fix formatter * relax GCC version requirement

fix

ba0ed05

Merge branch 'master' of https://github.com/open-mmlab/mmdeploy into …

fc13039

…nms_rotated

fix lint

b299fe5

fix lint

f35ae17

AllentDan reviewed Apr 14, 2022

View reviewed changes

zytx121 mentioned this pull request Apr 14, 2022

Support single stage rotated detector in MMRotate #349

Closed

6 tasks

grimoire previously approved these changes Apr 14, 2022

View reviewed changes

SingleZombie and others added 9 commits April 14, 2022 20:25

[Fix] MMEditing cannot save results when testing (open-mmlab#336)

d7adf81

* fix show * lint * remove redundant codes * resolve comment * type hint

docs(build): fix typo (open-mmlab#352)

89ce8e2

* docs(build): add missing build option * docs(build): add onnx install * style(doc): trim whitespace * docs(build): revert install onnx * docs(build): add ncnn LD_LIBRARY_PATH * docs(build): fix path error

fix openvino export tmp model, add binary flag (open-mmlab#353)

6aacede

init circleci (open-mmlab#348)

ade8e02

fix wrong input mat type (open-mmlab#362)

fdbd3d1

* fix wrong input mat type * fix lint

fix(docs): remove redundant doc tree (open-mmlab#360)

88062e9

fix missing ncnn_DIR & InferenceEngine_DIR (open-mmlab#364)

b9c5487

Merge branch 'master' of https://github.com/open-mmlab/mmdeploy into …

e75e725

…nms_rotated

update doc

3382a44

irexyc previously approved these changes Apr 18, 2022

View reviewed changes

grimoire changed the base branch from master to dev-v0.5.0 April 18, 2022 09:10

grimoire merged commit 9411fe0 into open-mmlab:dev-v0.5.0 Apr 18, 2022

This was referenced Apr 30, 2022

Support single stage rotated detector in MMRotate #427

Closed

Support single stage rotated detector in MMRotate #428

Merged

zytx121 mentioned this pull request Jun 10, 2022

How do I convert the R3DET model to ONNX format？ open-mmlab/mmrotate#345

Closed

ewernn pushed a commit to ewernn/mmdeploy that referenced this pull request Nov 17, 2025

Fix cub (open-mmlab#312)

f1e5acb

* fix cub path * use cmake source dir instead

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add nms_rotated ort op#312

Add nms_rotated ort op#312
grimoire merged 19 commits intoopen-mmlab:dev-v0.5.0from
zytx121:nms_rotated

zytx121 commented Apr 5, 2022

Uh oh!

codecov bot commented Apr 6, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AllentDan left a comment

Uh oh!

grimoire left a comment

Uh oh!

irexyc commented Apr 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

zytx121 commented Apr 5, 2022

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Uh oh!

codecov bot commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AllentDan left a comment

Choose a reason for hiding this comment

Uh oh!

grimoire left a comment

Choose a reason for hiding this comment

Uh oh!

irexyc commented Apr 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Apr 6, 2022 •

edited

Loading