feat(ui): add font-size support to SelectItem via SelectContext#27379
Merged
anuj-kumary merged 3 commits intomainfrom Apr 15, 2026
Merged
feat(ui): add font-size support to SelectItem via SelectContext#27379anuj-kumary merged 3 commits intomainfrom
anuj-kumary merged 3 commits intomainfrom
Conversation
Extends SelectContext to include fontSize so SelectItem inherits the font size configured on the parent Select, enabling consistent text sizing across both the trigger and dropdown items. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review ✅ ApprovedIntegrates font-size support into SelectItem using SelectContext to improve UI consistency. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
🟡 Playwright Results — all passed (15 flaky)✅ 3641 passed · ❌ 0 failed · 🟡 15 flaky · ⏭️ 84 skipped
🟡 15 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
chirag-madlani
approved these changes
Apr 15, 2026
RajdeepKushwaha5
added a commit
to RajdeepKushwaha5/OpenMetadata
that referenced
this pull request
Apr 16, 2026
…mplete PR open-metadata#27379 added fontSize as a required property to SelectContext but only updated select.tsx. This adds the missing fontSize property to combobox.tsx and autocomplete.tsx to fix the TypeScript build error (TS2741) that is currently blocking CI on all open PRs.
9 tasks
RajdeepKushwaha5
added a commit
to RajdeepKushwaha5/OpenMetadata
that referenced
this pull request
Apr 16, 2026
…mplete PR open-metadata#27379 added fontSize as a required property to SelectContext but only updated select.tsx. This adds the missing fontSize property to combobox.tsx and autocomplete.tsx to fix the TypeScript build error (TS2741) that is currently blocking CI on all open PRs.
RajdeepKushwaha5
added a commit
to RajdeepKushwaha5/OpenMetadata
that referenced
this pull request
Apr 16, 2026
…Autocomplete Unblocks CI on this PR. main is currently failing tsc --noEmit with TS2741 because open-metadata#27379 made fontSize a required field on SelectContext but only updated select.tsx. combobox.tsx and autocomplete.tsx also provide that context and were missed, cascading into all py-tests and Playwright failures on every open PR. Mirrors the fix in PR open-metadata#27435.
RajdeepKushwaha5
added a commit
to RajdeepKushwaha5/OpenMetadata
that referenced
this pull request
Apr 17, 2026
…Autocomplete Unblocks CI on this PR. main is currently failing tsc --noEmit with TS2741 because open-metadata#27379 made fontSize a required field on SelectContext but only updated select.tsx. combobox.tsx and autocomplete.tsx also provide that context and were missed, cascading into all py-tests and Playwright failures on every open PR. Mirrors the fix in PR open-metadata#27435.
RajdeepKushwaha5
added a commit
to RajdeepKushwaha5/OpenMetadata
that referenced
this pull request
Apr 17, 2026
…mplete PR open-metadata#27379 added fontSize as a required property to SelectContext but only updated select.tsx. This adds the missing fontSize property to combobox.tsx and autocomplete.tsx to fix the TypeScript build error (TS2741) that is currently blocking CI on all open PRs.
chirag-madlani
added a commit
that referenced
this pull request
Apr 20, 2026
…mplete (#27435) PR #27379 added fontSize as a required property to SelectContext but only updated select.tsx. This adds the missing fontSize property to combobox.tsx and autocomplete.tsx to fix the TypeScript build error (TS2741) that is currently blocking CI on all open PRs. Co-authored-by: Anujkumar Yadav <anujf0510@gmail.com> Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Extends fontSize prop support from the Select trigger button down to SelectItem dropdown options, so both the selected value display and the dropdown items use the same configured font size.
Problem
Previously, Select accepted a fontSize prop that only applied to the trigger button (the selected value display). The dropdown SelectItem components used a hardcoded tw:text-md class, so changing fontSize on Select had no effect on the dropdown list items the two were visually inconsistent.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>