Affected module
UI — openmetadata-ui-core-components
Describe the bug
Hey @anuj-kumary — your recent PR #27379 (feat(ui): add font-size support to SelectItem via SelectContext, commit 48ffbba4bb) added fontSize as a required property to the SelectContext type in select.tsx. It looks like combobox.tsx and autocomplete.tsx — which also provide SelectContext — were missed in the update:
combobox.tsx — SelectContext.Provider value={{ size }} → missing fontSize
autocomplete.tsx — selectContextValue = useMemo(() => ({ size: 'sm' as const }), []) → missing fontSize
This causes a TypeScript compilation error on every build:
error TS2741: Property 'fontSize' is missing in type '{ size: "sm" | "md" | "lg"; }'
but required in type '{ fontSize: "xs" | "sm" | "md" | "lg" | "xl"; size: "sm" | "md" | "lg"; }'.
Impact: This is currently blocking CI for all open PRs that trigger a UI build. Since the error is on main, rebasing doesn't help.
To Reproduce
- Checkout
main (any commit after 48ffbba4bb)
- Run TypeScript compilation:
cd openmetadata-ui-core-components/src/main/resources/ui
npx tsc --noEmit
- Observe the
TS2741 error in combobox.tsx and autocomplete.tsx
Alternatively, check the CI status on any currently open PR — the OpenMetadata UI - CI and related checks fail with this error.
Expected behavior
All SelectContext.Provider usages should include the required fontSize property. The TypeScript build should compile without errors.
Suggested fix
Add fontSize: 'md' (the same default used in select.tsx) to both providers:
combobox.tsx:
- <SelectContext.Provider value={{ size }}>
+ <SelectContext.Provider value={{ fontSize: 'md', size }}>
autocomplete.tsx:
- const selectContextValue = useMemo(() => ({ size: 'sm' as const }), []);
+ const selectContextValue = useMemo(
+ () => ({ fontSize: 'md' as const, size: 'sm' as const }),
+ []
+ );
I have a fix PR ready — will link it here shortly.
Version
Additional context
- The fix is a 2-line change with zero risk — just adding the missing required property with the same default value already used in
select.tsx
Affected module
UI —
openmetadata-ui-core-componentsDescribe the bug
Hey @anuj-kumary — your recent PR #27379 (
feat(ui): add font-size support to SelectItem via SelectContext, commit48ffbba4bb) addedfontSizeas a required property to theSelectContexttype inselect.tsx. It looks likecombobox.tsxandautocomplete.tsx— which also provideSelectContext— were missed in the update:combobox.tsx—SelectContext.Provider value={{ size }}→ missingfontSizeautocomplete.tsx—selectContextValue = useMemo(() => ({ size: 'sm' as const }), [])→ missingfontSizeThis causes a TypeScript compilation error on every build:
Impact: This is currently blocking CI for all open PRs that trigger a UI build. Since the error is on
main, rebasing doesn't help.To Reproduce
main(any commit after48ffbba4bb)cd openmetadata-ui-core-components/src/main/resources/ui npx tsc --noEmitTS2741error incombobox.tsxandautocomplete.tsxAlternatively, check the CI status on any currently open PR — the
OpenMetadata UI - CIand related checks fail with this error.Expected behavior
All
SelectContext.Providerusages should include the requiredfontSizeproperty. The TypeScript build should compile without errors.Suggested fix
Add
fontSize: 'md'(the same default used inselect.tsx) to both providers:combobox.tsx:autocomplete.tsx:I have a fix PR ready — will link it here shortly.
Version
mainbranch (post-commit48ffbba4bb, merged 2026-04-15)Additional context
select.tsx