feat!: add support for domains#271
Merged
federicobond merged 8 commits intoopen-feature:mainfrom Feb 20, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 94.40% 94.52% +0.11%
==========================================
Files 17 18 +1
Lines 447 493 +46
==========================================
+ Hits 422 466 +44
- Misses 25 27 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gruebel
reviewed
Feb 4, 2024
Member
gruebel
left a comment
There was a problem hiding this comment.
Due to the argument renaming it becomes a breaking change and then you actually could completely get rid of _provider and initialize _providers like this
_providers: typing.Dict[typing.Optional[str], AbstractProvider] = {None: NoOpProvider()}
beeme1mr
reviewed
Feb 6, 2024
531831a to
4d2dfdc
Compare
federicobond
commented
Feb 7, 2024
Member
Author
|
I introduced a ProviderRegistry in the last commit similar to the ones in other SDKs because the code was becoming a bit convoluted. |
beeme1mr
approved these changes
Feb 9, 2024
b71012e to
376802e
Compare
Member
Author
|
Rebased on top of latest |
376802e to
11feec1
Compare
beeme1mr
reviewed
Feb 15, 2024
acac4dd to
d1cc64c
Compare
toddbaert
approved these changes
Feb 20, 2024
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
d1cc64c to
0425a15
Compare
Merged
This was referenced Mar 15, 2024
kikihakiem
pushed a commit
to ResalApps/openfeature-python-sdk
that referenced
this pull request
Aug 28, 2025
…ure#271) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Adds support for domains with a minimalist implementation. Feedback is especially welcome around public APIs and backward compatibility issues.
Builds on top of #270
Related Issues
Refs #125
Follow-up Tasks