Skip to content

fix: fix types for HookContext.{client,provider}_metadata#233

Merged
beeme1mr merged 2 commits into
open-feature:mainfrom
federicobond:fix-types-2
Nov 7, 2023
Merged

fix: fix types for HookContext.{client,provider}_metadata#233
beeme1mr merged 2 commits into
open-feature:mainfrom
federicobond:fix-types-2

Conversation

@federicobond

@federicobond federicobond commented Nov 3, 2023

Copy link
Copy Markdown
Member

This PR

Corrects type information for some HookContext fields. Yup, it's ugly to prevent a circular import problem, there might be a better way to do it but I haven't found it.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@codecov

codecov Bot commented Nov 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #233 (e419afc) into main (db50494) will decrease coverage by 0.40%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   93.84%   93.45%   -0.40%     
==========================================
  Files          16       16              
  Lines         439      443       +4     
==========================================
+ Hits          412      414       +2     
- Misses         27       29       +2     
Flag Coverage Δ
unittests 93.45% <66.66%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openfeature/hook/__init__.py 79.41% <66.66%> (-3.93%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@beeme1mr beeme1mr merged commit 4bdd384 into open-feature:main Nov 7, 2023
@federicobond federicobond deleted the fix-types-2 branch November 7, 2023 16:50
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
…spec digest to 18cde17 (open-feature#233)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants