Conversation
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Member
|
Should we actually consider this a |
Member
Author
|
I originally opened this as a refactor but we do add domain to event payloads. That's why I changed it to a feature. I'm good either way though. Whatever would be the most clear to users reading the release notes. |
lukas-reining
approved these changes
Feb 1, 2024
Member
lukas-reining
left a comment
There was a problem hiding this comment.
Looks good, left one thought.
toddbaert
reviewed
Feb 2, 2024
toddbaert
reviewed
Feb 2, 2024
toddbaert
reviewed
Feb 2, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Member
|
@beeme1mr I found a few missing test assertions of |
toddbaert
approved these changes
Feb 2, 2024
federicobond
reviewed
Feb 3, 2024
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Member
Author
|
I've addressed all the feedback and included a bug fix. I'll merge this tomorrow unless I hear any objections. Thanks! |
This was referenced Feb 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.26](core-v0.0.25...core-v0.0.26) (2024-02-22) ### ✨ New Features * add support for domains ([#805](#805)) ([98ba00a](98ba00a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: openfeature-peer-update-bot <openfeature-peer-update-bot@openfeature.dev> Co-authored-by: openfeature-peer-update-bot <openfeature-peer-update-bot@openfeature.dev>
toddbaert
pushed a commit
that referenced
this pull request
Feb 22, 2024
🤖 I have created a release *beep* *boop* --- ## [1.12.0](server-sdk-v1.11.0...server-sdk-v1.12.0) (2024-02-22) ### ✨ New Features * add support for domains ([#805](#805)) ([98ba00a](98ba00a)) ### 🧹 Chore * **main:** release core 0.0.26 ([#823](#823)) ([2fc38bd](2fc38bd)) ### 📚 Documentation * add missing punctuation to readme ([4c73189](4c73189)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
toddbaert
added a commit
that referenced
this pull request
Feb 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.13](web-sdk-v0.4.12...web-sdk-v0.4.13) (2024-02-22) ### ✨ New Features * add support for domains ([#805](#805)) ([98ba00a](98ba00a)) ### 🧹 Chore * **main:** release core 0.0.26 ([#823](#823)) ([2fc38bd](2fc38bd)) ### 📚 Documentation * fix runsOn example on readme ([1096ae5](1096ae5)) * improved grammar, added punction to readme ([70bd33d](70bd33d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
This was referenced Mar 12, 2024
This was referenced Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Addresses
fixes #820 4aa9657
Notes
This change is based on this spec change. I tried to make it a non-breaking change but I may have missed an untested condition. Please carefully review to make sure I didn't miss anything.
Follow-up Tasks