Merged
Conversation
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
…lue attribute Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
dyladan
reviewed
Feb 4, 2025
dyladan
left a comment
There was a problem hiding this comment.
Looks semantically correct to me. Left a couple comments about style but they're really just nits. The one where the names don't match (code/type) is the only one that I think is an actual mistake.
lukas-reining
approved these changes
Feb 4, 2025
kinyoklion
approved these changes
Feb 4, 2025
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
toddbaert
reviewed
Feb 7, 2025
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
approved these changes
Feb 7, 2025
…ror handling Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
🤖 I have created a release *beep* *boop* --- ## [1.7.0](core-v1.6.0...core-v1.7.0) (2025-02-07) ### ✨ New Features * add telemetry helper utils ([#1120](#1120)) ([1e93b3c](1e93b3c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
This was referenced Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1118
Notes
I've omitted value type because it is likely to be declined in the OTel spec and adds complexity. We should consider removing that section from appendix d.