feat!: made EvaluationContext fields unexported with a constructor and setters to enforce immutability#91
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 69.24% 69.68% +0.43%
==========================================
Files 7 8 +1
Lines 569 597 +28
==========================================
+ Hits 394 416 +22
- Misses 158 164 +6
Partials 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…d setters to enforce immutability Signed-off-by: Skye Gill <gill.skye95@gmail.com>
1f3b60a to
a1fbbbc
Compare
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
4eb9578 to
68166f3
Compare
toddbaert
reviewed
Oct 6, 2022
toddbaert
left a comment
Member
There was a problem hiding this comment.
This looks good.
I think the only thing I'm missing here is the lock on global providers and hooks, as well as client hooks. We probably want to read-lock all of these during evaluation, and write lock them during mutation.
Contributor
Author
Great points. I've tackled this in another PR: #93 |
toddbaert
approved these changes
Oct 6, 2022
68166f3 to
68adbb1
Compare
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
68adbb1 to
610af7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.