fix: locks on singleton and client state to ensure thread safety#93
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 70.21% 73.04% +2.83%
==========================================
Files 8 8
Lines 601 653 +52
==========================================
+ Hits 422 477 +55
+ Misses 162 159 -3
Partials 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
toddbaert
reviewed
Oct 6, 2022
40af78d to
c2c10a3
Compare
james-milligan
approved these changes
Oct 7, 2022
beeme1mr
approved these changes
Oct 7, 2022
toddbaert
reviewed
Oct 7, 2022
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
6d76407 to
06ac26c
Compare
skyerus
commented
Oct 11, 2022
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
This PR adds multi-read/single-write locks to both the global singleton and the client. Particularly it addresses problems relating to the providers/hooks being mutated while an evaluation is occurring. This is especially important since some providers have provider hooks, and if we don't lock, it's possible hooks from provider1 run on provider2 if an interleaving thread switched the provider.
I've opted for the approach of locking a provider and its hooks to an evaluation transaction. Another thread is free to set a new provider but any ongoing transactions will carry on using the existing provider and its hooks.
Related Issues
Fixes #90
Notes
Follow-up Tasks
How to test