feat: add OTel event creation util func#325
Merged
toddbaert merged 13 commits intoopen-feature:mainfrom Feb 27, 2025
Merged
Conversation
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 86.78% 88.28% +1.49%
==========================================
Files 13 14 +1
Lines 1362 1408 +46
==========================================
+ Hits 1182 1243 +61
+ Misses 156 141 -15
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…e based on codecov report Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
…o set what is being set by the if-else Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
chrfwow
approved these changes
Feb 21, 2025
lukas-reining
approved these changes
Feb 21, 2025
bbland1
commented
Feb 24, 2025
beeme1mr
reviewed
Feb 24, 2025
Member
beeme1mr
left a comment
There was a problem hiding this comment.
I had a few thoughts after rereviewing this. I'd consider them all optional but worth consider. Thanks!
…dability Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
liran2000
suggested changes
Feb 25, 2025
Member
liran2000
left a comment
There was a problem hiding this comment.
Some const values were not used, left comments on what to replace.
no linter caught this.
Member
Author
Nice catch! It took me a moment to see how I missed using the missing const values. Thanks! |
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
liran2000
approved these changes
Feb 26, 2025
toddbaert
added a commit
to open-feature/community
that referenced
this pull request
Feb 27, 2025
@bbland1 has contributed 2 recent changes to the Go SDK: - open-feature/go-sdk#325 - open-feature/go-sdk#328 @bbland1 when merged, this PR will add you to the org. It comes with no obligation but it's the first step on the https://github.com/open-feature/community/blob/main/CONTRIBUTOR_LADDER.md. Please approve or 👍 this PR to signal your interest! Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #322
How to test