chore: deprecate fractionalEvaluation for fractional by toddbaert · Pull Request #873 · open-feature/flagd

toddbaert · 2023-08-28T23:20:28Z

deprecates fractionalEvaluation in favor of fractional
adds evaluation names to their implementations to bind them more closely

2023-08-28T19:22:53.098-0400    warn    eval/legacy_fractional_evaluation.go:32 fractionalEvaluation is deprecated, please use fractional, see: https://flagd.dev/concepts/#migrating-from-legacy-fractionalevaluation

cc @craigpastro

fixes: #871

netlify · 2023-08-28T23:20:32Z

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name	Link
🔨 Latest commit	`fc6bd83`
🔍 Latest deploy log	https://app.netlify.com/sites/polite-licorice-3db33c/deploys/64ee34a87d1ed20008a711e2

codecov · 2023-08-28T23:24:12Z

Codecov Report

Merging #873 (fc6bd83) into main (da30b7b) will decrease coverage by 0.07%.
The diff coverage is 71.87%.

❗ Current head fc6bd83 differs from pull request most recent head e7a8569. Consider uploading reports for the commit e7a8569 to get more accurate results

@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   72.80%   72.73%   -0.07%     
==========================================
  Files          27       28       +1     
  Lines        2765     2857      +92     
==========================================
+ Hits         2013     2078      +65     
- Misses        665      683      +18     
- Partials       87       96       +9

Files Changed	Coverage Δ
core/pkg/eval/fractional_evaluation.go	`72.15% <ø> (ø)`
core/pkg/eval/semver_evaluation.go	`100.00% <ø> (ø)`
core/pkg/eval/string_comparison_evaluation.go	`100.00% <ø> (ø)`
core/pkg/eval/legacy_fractional_evaluation.go	`68.96% <68.96%> (ø)`
core/pkg/runtime/from_config.go	`60.55% <100.00%> (+0.92%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

core/pkg/eval/string_comparison_evaluation.go

craigpastro

LGTM 🙌

docs/configuration/fractional_evaluation.md

web-docs/concepts/index.md

core/pkg/eval/legacy_fractional_evaluation.go

Kavindu-Dodan

Added an optional suggestion, otherwise looks good 👍

* deprecates fractionalEvaluation in favor of fractional * adds evaluation names to their implementations to bind them more closely Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

docs/configuration/fractional_evaluation.md

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.6.4</summary> ## [0.6.4](flagd/v0.6.3...flagd/v0.6.4) (2023-08-30) ### 🐛 Bug Fixes * **deps:** update module github.com/cucumber/godog to v0.13.0 ([#855](#855)) ([5b42486](5b42486)) * **deps:** update module github.com/open-feature/flagd/core to v0.6.3 ([#794](#794)) ([9671964](9671964)) ### 🧹 Chore * **deps:** update golang docker tag to v1.21 ([#822](#822)) ([effe29d](effe29d)) </details> <details><summary>flagd-proxy: 0.2.9</summary> ## [0.2.9](flagd-proxy/v0.2.8...flagd-proxy/v0.2.9) (2023-08-30) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.6.3 ([#794](#794)) ([9671964](9671964)) ### 🧹 Chore * **deps:** update golang docker tag to v1.21 ([#822](#822)) ([effe29d](effe29d)) </details> <details><summary>core: 0.6.4</summary> ## [0.6.4](core/v0.6.3...core/v0.6.4) (2023-08-30) ### 🐛 Bug Fixes * **deps:** update kubernetes packages to v0.28.0 ([#841](#841)) ([cc195e1](cc195e1)) * **deps:** update kubernetes packages to v0.28.1 ([#860](#860)) ([f3237c2](f3237c2)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.2.36 ([#799](#799)) ([fa4da4b](fa4da4b)) * **deps:** update module golang.org/x/crypto to v0.12.0 ([#797](#797)) ([edae3fd](edae3fd)) * **deps:** update module golang.org/x/net to v0.14.0 ([#798](#798)) ([92c2f26](92c2f26)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.15.1 ([#795](#795)) ([13d62fd](13d62fd)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.16.0 ([#856](#856)) ([88d832a](88d832a)) ### ✨ New Features * add flag key to hash in fractional evaluation ([#847](#847)) ([ca6a35f](ca6a35f)) * add gRPC healthchecks ([#863](#863)) ([da30b7b](da30b7b)) * support nested props in fractional evaluator ([#869](#869)) ([50ff739](50ff739)) ### 🧹 Chore * deprecate fractionalEvaluation for fractional ([#873](#873)) ([243fef9](243fef9)) * replace xxh3 with murmur3 in bucket algorithm ([#846](#846)) ([c3c9e4e](c3c9e4e)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

toddbaert requested a review from a team August 28, 2023 23:20

toddbaert force-pushed the chore/deprecated-old-fe branch from 0dc659d to 7319030 Compare August 28, 2023 23:20

toddbaert requested review from Kavindu-Dodan, beeme1mr and thisthat August 28, 2023 23:21

toddbaert closed this Aug 28, 2023

toddbaert reopened this Aug 28, 2023

toddbaert requested a review from bacherfl August 28, 2023 23:36

toddbaert mentioned this pull request Aug 28, 2023

Deprecate "fractionalEvaluation", rename to "fractional". #871

Closed

toddbaert force-pushed the chore/deprecated-old-fe branch from a98778d to 17fbc1e Compare August 29, 2023 00:19

toddbaert changed the title ~~chore!: deprecate old fractional eval~~ chore!: deprecate fractionalEvaluation for fractional Aug 29, 2023

craigpastro reviewed Aug 29, 2023

View reviewed changes

core/pkg/eval/string_comparison_evaluation.go Show resolved Hide resolved

craigpastro approved these changes Aug 29, 2023

View reviewed changes

beeme1mr reviewed Aug 29, 2023

View reviewed changes

docs/configuration/fractional_evaluation.md Show resolved Hide resolved

beeme1mr reviewed Aug 29, 2023

View reviewed changes

web-docs/concepts/index.md Show resolved Hide resolved

toddbaert requested a review from beeme1mr August 29, 2023 13:01

toddbaert changed the title ~~chore!: deprecate fractionalEvaluation for fractional~~ chore: deprecate fractionalEvaluation for fractional Aug 29, 2023

Kavindu-Dodan reviewed Aug 29, 2023

View reviewed changes

core/pkg/eval/legacy_fractional_evaluation.go Show resolved Hide resolved

Kavindu-Dodan approved these changes Aug 29, 2023

View reviewed changes

toddbaert and others added 7 commits August 29, 2023 13:43

chore!: deprecate old fractional eval

b035c72

* deprecates fractionalEvaluation in favor of fractional * adds evaluation names to their implementations to bind them more closely Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

fixup: lint

3ffefdd

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Fixup: doc typo

307f08b

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Fixup: Doc typo

70e8381

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

chore: comment typo

61aa480

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

fixup: docs

6876125

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Update core/pkg/eval/legacy_fractional_evaluation.go

fc6bd83

Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

toddbaert force-pushed the chore/deprecated-old-fe branch from ab29ca9 to fc6bd83 Compare August 29, 2023 17:43

craigpastro reviewed Aug 29, 2023

View reviewed changes

docs/configuration/fractional_evaluation.md Show resolved Hide resolved

fixup: JsonLogic styling

e7a8569

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

beeme1mr approved these changes Aug 29, 2023

View reviewed changes

toddbaert merged commit 243fef9 into main Aug 29, 2023

toddbaert deleted the chore/deprecated-old-fe branch August 29, 2023 21:32

github-actions bot mentioned this pull request Aug 29, 2023

chore: release main #796

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: deprecate fractionalEvaluation for fractional#873

chore: deprecate fractionalEvaluation for fractional#873
toddbaert merged 8 commits intomainfrom
chore/deprecated-old-fe

toddbaert commented Aug 28, 2023 •

edited

Loading

Uh oh!

netlify bot commented Aug 28, 2023 •

edited

Loading

Uh oh!

codecov bot commented Aug 28, 2023 •

edited

Loading

Uh oh!

Uh oh!

craigpastro left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kavindu-Dodan left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

toddbaert commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for polite-licorice-3db33c canceled.

Uh oh!

codecov bot commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

craigpastro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kavindu-Dodan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

toddbaert commented Aug 28, 2023 •

edited

Loading

netlify bot commented Aug 28, 2023 •

edited

Loading

codecov bot commented Aug 28, 2023 •

edited

Loading