docs: add specification for in-process flagd provider implementations#848
Merged
toddbaert merged 20 commits intoopen-feature:mainfrom Aug 24, 2023
Merged
Conversation
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
beeme1mr
reviewed
Aug 21, 2023
docs/other_resources/in-process-providers/evaluators/fractional_evaluation.md
Outdated
Show resolved
Hide resolved
Member
|
Thanks @bacherfl, I'll review this first thing tomorrow! |
Contributor
|
Overal looks really good 🙌 One suggestion, IMO it is good to add a section explaining what in-memory flagd provider is and why it is useful. For example - flagd by default is a remote deployment (sidecar injection) where as the in-memory provider is designed to be embedded into the application. And given the embedded nature, the evaluations do not require communication outside of the process, which is desired by some architectures. |
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…l_evaluation.md Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Contributor
Author
good suggestion, will add that to the document :) |
… and flagd Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
toddbaert
reviewed
Aug 22, 2023
docs/other_resources/in-process-providers/evaluators/fractional_evaluation.md
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Aug 22, 2023
docs/other_resources/in-process-providers/evaluators/semver_evaluation.md
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Aug 22, 2023
docs/other_resources/in-process-providers/evaluators/semver_evaluation.md
Show resolved
Hide resolved
toddbaert
reviewed
Aug 22, 2023
docs/other_resources/in-process-providers/evaluators/string_comparison_evaluation.md
Show resolved
Hide resolved
…aluation.md Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…mparison_evaluation.md Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
This was referenced Aug 22, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
toddbaert
reviewed
Aug 23, 2023
docs/other_resources/in-process-providers/evaluators/fractional_evaluation.md
Outdated
Show resolved
Hide resolved
toddbaert
approved these changes
Aug 23, 2023
Member
toddbaert
left a comment
There was a problem hiding this comment.
Approved pending #848 (comment)
Kavindu-Dodan
approved these changes
Aug 23, 2023
beeme1mr
approved these changes
Aug 23, 2023
docs/other_resources/in-process-providers/evaluators/fractional_evaluation.md
Outdated
Show resolved
Hide resolved
…l_evaluation.md Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
toddbaert
approved these changes
Aug 24, 2023
toddbaert
added a commit
that referenced
this pull request
Aug 28, 2023
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->
## This PR
<!-- add the description of the PR here -->
This PR adds the ability to use nested properties for the bucket key in
fractional evaluation. It is a breaking change from the current
behaviour. If the bucket key is not provided it will default to `{"cat":
[{"var":"$flagd.flagKey"}, {"var":"targetingKey"}]}`.
@toddbaert I am not sure that my approach to the missing bucket key is
the best. I would have preferred to add `{"cat":
[{"var":"$flagd.flagKey"}, {"var":"targetingKey"}]}` to the targeting
object and let JsonLogic handle it, but it would be a bit clumsy and
involve string manipulation. I don't think there is a nice way to do it,
but I'll play around a bit more.
### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->
See #848.
Closes #843.
### Notes
<!-- any additional notes for this PR -->
### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->
### How to test
<!-- if applicable, add testing instructions under this section -->
---------
Signed-off-by: Craig Pastro <pastro.craig@gmail.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #842
This PR adds the specification for in-process flagd providers. For now I have added this to the
other_ressourcessection of the docs, but please let me know if another directory would be more fitting for this document