Closed
Conversation
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
toddbaert
commented
May 27, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
added a commit
to open-feature/flagd-schemas
that referenced
this pull request
May 27, 2024
This PR - adds full versioning to the json schema (meaning the `$id` now has a full version string in it, like: `https://flagd.dev/schema/v0.2.5/flags.json`) - adds automation to update this with new releases of the json module - note there's no way to use the traditional release please versioning with comment to update a substring of a json value, so I've had to hack that in myself. Next steps will be to: - serve each version of the schema at flagd.dev: open-feature/flagd#1321 - add support in providers for checking this Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Kavindu-Dodan
approved these changes
May 28, 2024
Contributor
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
This conversation exist, but otherwise this looks good
Member
Author
|
I'm going to close this. Reasoning here: open-feature/flagd-schemas#166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds make target that pulls the specified version of the flagd-json-schema and serves it at the appropriate location