feat(575): make sure that we convert raw to typed in registries#962
Closed
matthiasbruns wants to merge 3 commits into
Closed
feat(575): make sure that we convert raw to typed in registries#962matthiasbruns wants to merge 3 commits into
matthiasbruns wants to merge 3 commits into
Conversation
Contributor
Author
|
waiting for @fabianburth pr's |
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
196140d to
234cbae
Compare
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
maybe I have this wrong again but didnt we agree that it would be acceptable to instead do this conversion only in the inbuilt types because not all registries have the ability for conversion?
Contributor
Author
|
Yeah you are right - the first thing I did was rebasing all my PRs. |
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Apr 17, 2026
Aligns with open-component-model#962 UpperCamelCase convention. LocalBlob is now the primary type for marshaling; localBlob preserved as legacy alias for backward compatibility. Both descriptor/v2 and descriptor/runtime updated. Adds scheme resolution tests for all 4 aliases (versioned/unversioned, primary/legacy), updates marshal/unmarshal assertions, and adds legacy backward-compat test coverage. Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Apr 21, 2026
Aligns with open-component-model#962 UpperCamelCase convention. LocalBlob is now the primary type for marshaling; localBlob preserved as legacy alias for backward compatibility. Both descriptor/v2 and descriptor/runtime updated. Adds scheme resolution tests for all 4 aliases (versioned/unversioned, primary/legacy), updates marshal/unmarshal assertions, and adds legacy backward-compat test coverage. Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-behalf-of: SAP matthias.bruns@sap.com
What this PR does / why we need it
In #913 we found out that the plugin registries are not prepared to work with
runtime.Rawspecs. In the current resolver/glob implementation, we do not have aruntime.Typedrepo anymore but aruntime.Rawrepo. This PR allows the use ofruntime.Rawin the plugin registries where needed.Which issue(s) this PR fixes
Contributes: open-component-model/ocm-project#575