fix(oci): fix repository detection for OCI URLs with IP addresses#894
Merged
piotrjanik merged 2 commits intoSep 17, 2025
Merged
Conversation
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
This looks great already! Do you mind adding a test permutation in https://github.com/open-component-model/open-component-model/pull/894/files#diff-09d82ce22ddbe9276d3d6a4040e6a94f78a6647a4d7adddd5748de29c25ed2cdL287 for the ip case? then we have a lot more tests running against this
674f345 to
336d42f
Compare
jakobmoellerdev
approved these changes
Sep 17, 2025
fabianburth
approved these changes
Sep 17, 2025
<!-- markdownlint-disable MD041 --> Previously, repository references in a format of IP:PORT were incorrectly recognized due to a parsing error. This fix ensures that repositories behind an IP address are correctly detected. <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes open-component-model/ocm-project#651 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
<!-- markdownlint-disable MD041 --> Previously, repository references in a format of IP:PORT were incorrectly recognized due to a parsing error. This fix ensures that repositories behind an IP address are correctly detected. <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes open-component-model/ocm-project#651 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
c439102 to
7d5cb86
Compare
matthiasbruns
pushed a commit
to matthiasbruns/open-component-model
that referenced
this pull request
Sep 18, 2025
…en-component-model#894) <!-- markdownlint-disable MD041 --> Previously, repository references in the format of IP:PORT were incorrectly recognised due to a parsing error. This fix ensures that repositories behind an IP address are correctly detected. <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes open-component-model/ocm-project#651 --------- Signed-off-by: Piotr Janik <piotr.janik@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, repository references in the format of IP:PORT were incorrectly recognised due to a parsing error. This fix ensures that repositories behind an IP address are correctly detected.
Fixes open-component-model/ocm-project#651