fix(ctf): Add support for recognizing additional CTF archive files: tar.gz, tgz, tar (#651)#882
Merged
piotrjanik merged 2 commits intoSep 16, 2025
Conversation
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
The issue issue number you are linking points to a closed PR. Maybe you were trying to cross reference something else? Would you mind double checking that please?
Contributor
Author
I meant issue, not PR. Providing the full link helped :) |
jakobmoellerdev
approved these changes
Sep 16, 2025
Skarlso
approved these changes
Sep 16, 2025
Member
|
@piotrjanik please sign your commits so this can be merged :) |
70fad88 to
57a97ca
Compare
…ar.gz, tgz, tar (open-component-model#651) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Previously, repository references ending with archive extensions (like `transport-archive.tar.gz`) could be misidentified as a hostname due to the presence of dots in the path. This fix ensures that archives such as tar.gz are correctly detected. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes open-component-model#651 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
…ar.gz, tgz, tar (open-component-model#651) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Previously, repository references ending with archive extensions (like `transport-archive.tar.gz`) could be misidentified as a hostname due to the presence of dots in the path. This fix ensures that archives such as tar.gz are correctly detected. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes open-component-model/ocm-project#651 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
57a97ca to
8902430
Compare
jakobmoellerdev
pushed a commit
to jakobmoellerdev/open-component-model
that referenced
this pull request
Sep 17, 2025
…ar.gz, tgz, tar (open-component-model#651) (open-component-model#882) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Previously, repository references ending with archive extensions (like `transport-archive.tar.gz`) could be misidentified as a hostname due to the presence of dots in the path. This fix ensures that archives such as tar.gz are correctly detected. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes open-component-model/ocm-project#651 --------- Signed-off-by: Piotr Janik <piotr.janik@sap.com>
matthiasbruns
pushed a commit
to matthiasbruns/open-component-model
that referenced
this pull request
Sep 18, 2025
…ar.gz, tgz, tar (open-component-model#651) (open-component-model#882) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Previously, repository references ending with archive extensions (like `transport-archive.tar.gz`) could be misidentified as a hostname due to the presence of dots in the path. This fix ensures that archives such as tar.gz are correctly detected. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes open-component-model/ocm-project#651 --------- Signed-off-by: Piotr Janik <piotr.janik@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Previously, repository references ending with archive extensions (like
transport-archive.tar.gz) could be misidentified as a hostname due to the presence of dots in the path. This fix ensures that archives such as tar.gz are correctly detected.Which issue(s) this PR fixes
Fixes open-component-model/ocm-project#651