feat(verification): update resolver handling for component verification#872
Merged
jakobmoellerdev merged 3 commits intoSep 15, 2025
Conversation
#### What this commit does - Refactored `VerifyComponentVersion` to directly accept `resolver` as a parameter instead of constructing it internally. - Simplified resolver initialization across various controllers by introducing `NewSessionResolver` abstraction. - Updated tests to accommodate the modified `VerifyComponentVersion` signature and resolver management. #### Why this is needed - Enhances flexibility by allowing external control over resolver initialization. - Reduces redundancy in resolver creation, improving code maintainability. - Aligns with the overall goal of modular and testable component verification logic. Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
…lex paths #### What this commit does - Introduced `ResolveResourceReference` function to resolve resource references within component versions. - Added `ResolveReferencePath` to support navigating complex reference paths between components. - Updated `GetResourceAccessForComponentVersion` to leverage the new resolution logic instead of the previously direct approach. #### Why this is needed - Provides robust handling for cases where resource references involve multiple levels of indirection. - Enhances flexibility in managing complex dependency chains across component versions. - Aligns with the goal of modular and maintainable resource access logic. Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
d82b6ed to
433966d
Compare
Skarlso
approved these changes
Sep 14, 2025
fabianburth
approved these changes
Sep 15, 2025
jakobmoellerdev
added a commit
to jakobmoellerdev/open-component-model
that referenced
this pull request
Sep 17, 2025
…on (open-component-model#872) #### What this commit does - Refactored `VerifyComponentVersion` to directly accept `resolver` as a parameter instead of constructing it internally. - Simplified resolver initialization across various controllers by introducing `NewSessionResolver` abstraction. - Updated tests to accommodate the modified `VerifyComponentVersion` signature and resolver management. #### Why this is needed - Speeds up resolution of CVs across all controllers - Enhances flexibility by allowing external control over resolver initialization. - Reduces redundancy in resolver creation, improving code maintainability. - Aligns with the overall goal of modular and testable component verification logic. --------- Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
matthiasbruns
pushed a commit
to matthiasbruns/open-component-model
that referenced
this pull request
Sep 18, 2025
…on (open-component-model#872) #### What this commit does - Refactored `VerifyComponentVersion` to directly accept `resolver` as a parameter instead of constructing it internally. - Simplified resolver initialization across various controllers by introducing `NewSessionResolver` abstraction. - Updated tests to accommodate the modified `VerifyComponentVersion` signature and resolver management. #### Why this is needed - Speeds up resolution of CVs across all controllers - Enhances flexibility by allowing external control over resolver initialization. - Reduces redundancy in resolver creation, improving code maintainability. - Aligns with the overall goal of modular and testable component verification logic. --------- Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this commit does
VerifyComponentVersionto directly acceptresolveras a parameter instead of constructing it internally.NewSessionResolverabstraction.VerifyComponentVersionsignature and resolver management.Why this is needed