feat: setup get component version command#82
Merged
jakobmoellerdev merged 40 commits intoMay 15, 2025
Merged
Conversation
this sets up the get component version command. This is a very early PR that we will need to split up into multiple sub PRs with corrections in modules but it serves as an integration point.
# Conflicts: # bindings/go/oci/spec/repository/scheme.go # bindings/go/oci/spec/repository/v1/oci/repository.go # bindings/go/oci/spec/repository/v1/oci/zz_generated.deepcopy.go # bindings/go/oci/spec/repository/v1/oci/zz_generated.ocm_type.go # cli/cmd/root.go # cli/go.mod # cli/go.sum # cli/internal/reference/compref/compref.go # cli/internal/reference/compref/compref_test.go # cli/log/flag.go # docs/reference/cli/ocm.md # docs/reference/cli/ocm_completion.md # docs/reference/cli/ocm_completion_bash.md # docs/reference/cli/ocm_completion_fish.md # docs/reference/cli/ocm_completion_powershell.md # docs/reference/cli/ocm_completion_zsh.md # docs/reference/cli/ocm_generate.md
# Conflicts: # bindings/go/oci/internal/log/logging.go
# Conflicts: # bindings/go/oci/credentials/docker_config.go # bindings/go/oci/spec/credentials/scheme.go # bindings/go/oci/spec/credentials/v1/docker_config.go
# Conflicts: # bindings/go/credentials/go.sum # bindings/go/credentials/graph_test.go # bindings/go/plugin/go.mod # bindings/go/plugin/go.sum # bindings/go/plugin/internal/testplugin/main.go # bindings/go/plugin/manager/manager.go # bindings/go/plugin/manager/registries/componentversionrepository/endpoints_function_test.go # bindings/go/plugin/manager/registries/componentversionrepository/registry.go # bindings/go/plugin/manager/registries/credentialrepository/graph_integration.go # bindings/go/plugin/manager/types/types.go
Member
Author
|
This can now be started for a review but I still need to start adding tests as well as the When asking around it seemed to become clear that most people actually do not even use recursive right now so I decided to not implement this for the first version. This can always be added afterwards. |
Skarlso
reviewed
May 12, 2025
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
Just first run. Generally, this is gorgeous. :) 👍 I have a few questions, then I would like to run this actually locally once I have more time.
Skarlso
reviewed
May 14, 2025
Skarlso
reviewed
May 15, 2025
Skarlso
previously approved these changes
May 15, 2025
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
LGTM, nice work! :nod-cry:
Skarlso
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this sets up the get component version command. This is a very early PR that we will need to split up into multiple sub PRs with corrections in modules but it serves as an integration point.
What this PR does / why we need it
This implements the Get Component Version command as described in the reference documentation. Not included are things such as reference lookups and other smaller features that are present in old OCM but not new OCM. Nevertheless it will serve as a starting point for us. Depending on how we progress, we will either get this merged in with hardcoded oci support or with plugin support already
Which issue(s) this PR fixes
Eventually fixes open-component-model/ocm-project#473 but not before this needs to be extremely slimmed down and broken into various subissues in open-component-model/ocm-project#448.
fix #82