chore(deps): update golang:1.25 docker digest to 5e856b8#786
Closed
ocmbot[bot] wants to merge 1 commit into
Closed
chore(deps): update golang:1.25 docker digest to 5e856b8#786ocmbot[bot] wants to merge 1 commit into
ocmbot[bot] wants to merge 1 commit into
Conversation
Contributor
Author
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
fabianburth
added a commit
to fabianburth/open-component-model
that referenced
this pull request
Mar 24, 2026
When helm input method generates consumer identities for OCI repository URLs (oci://), it now returns type "OCIRegistry" instead of "HelmChartRepository". This allows the OCI credential repository plugin to match and resolve credentials correctly. After issue open-component-model#786 fix, the OCI credential repository plugin only handles OCIRegistry type, which caused credential lookup to fail for OCI-hosted Helm charts. This change aligns the consumer identity type with the actual protocol. Non-OCI URLs (http://, https://) continue using HelmChartRepository type for backward compatibility. Refs: open-component-model/ocm-project#967 Signed-off-by: Fabian Burth <fabian.burth@sap.com>
5 tasks
fabianburth
added a commit
that referenced
this pull request
Mar 26, 2026
## Summary - Fix consumer identity type for OCI-based Helm repositories to return `OCIRegistry` instead of `HelmChartRepository` when the URL uses `oci://` scheme - Add support for `accessToken` credential mapping for OCI registries (token is mapped to password for basic auth when password is not present) This resolves credential lookup failures for Helm charts hosted on OCI registries after issue #786 fix removed the OCI fallback for `AnyConsumerIdentityType`. ## Changes 1. **Consumer identity type fix** (`bindings/go/helm/input/method.go`, `bindings/go/helm/access/access.go`): - Detect `oci://` scheme and return `OCIRegistry` consumer identity type - Non-OCI URLs (http://, https://) continue using `HelmChartRepository` for backward compatibility 2. **Credential mapping** (`bindings/go/helm/internal/download/download.go`): - When `password` is not present but `accessToken` is, map the token to password for basic auth - Enables token-based authentication with OCI registries like GitHub Container Registry ## Test plan - [x] Unit tests added for OCI scheme detection in both input and access methods - [x] Existing tests updated to expect `OCIRegistry` type for OCI URLs - [x] All helm module tests pass - [x] Linter passes - [x] compiled the cli with go work and tested it against a private oci helm chart Closes open-component-model/ocm-project#967 --------- Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
859b0be->5e856b8Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.