Skip to content

chore(deps): update golang:1.25 docker digest to 5e856b8#786

Closed
ocmbot[bot] wants to merge 1 commit into
mainfrom
renovate/golang-1.25
Closed

chore(deps): update golang:1.25 docker digest to 5e856b8#786
ocmbot[bot] wants to merge 1 commit into
mainfrom
renovate/golang-1.25

Conversation

@ocmbot

@ocmbot ocmbot Bot commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
golang stage digest 859b0be -> 5e856b8

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@ocmbot ocmbot Bot requested a review from a team as a code owner September 4, 2025 06:53
@github-actions github-actions Bot added kind/chore chore, maintenance, etc. kind/dependency dependency update, etc. size/xs Extra small labels Sep 4, 2025
@ocmbot

ocmbot Bot commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the golang 5e856b8 update again.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@ocmbot ocmbot Bot deleted the renovate/golang-1.25 branch September 4, 2025 07:13
fabianburth added a commit to fabianburth/open-component-model that referenced this pull request Mar 24, 2026
When helm input method generates consumer identities for OCI repository
URLs (oci://), it now returns type "OCIRegistry" instead of
"HelmChartRepository". This allows the OCI credential repository plugin
to match and resolve credentials correctly.

After issue open-component-model#786 fix, the OCI credential repository plugin only handles
OCIRegistry type, which caused credential lookup to fail for OCI-hosted
Helm charts. This change aligns the consumer identity type with the
actual protocol.

Non-OCI URLs (http://, https://) continue using HelmChartRepository
type for backward compatibility.

Refs: open-component-model/ocm-project#967
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
fabianburth added a commit that referenced this pull request Mar 26, 2026
## Summary

- Fix consumer identity type for OCI-based Helm repositories to return
`OCIRegistry` instead of `HelmChartRepository` when the URL uses
`oci://` scheme
- Add support for `accessToken` credential mapping for OCI registries
(token is mapped to password for basic auth when password is not
present)

This resolves credential lookup failures for Helm charts hosted on OCI
registries after issue #786 fix removed the OCI fallback for
`AnyConsumerIdentityType`.

## Changes

1. **Consumer identity type fix** (`bindings/go/helm/input/method.go`,
`bindings/go/helm/access/access.go`):
- Detect `oci://` scheme and return `OCIRegistry` consumer identity type
- Non-OCI URLs (http://, https://) continue using `HelmChartRepository`
for backward compatibility

2. **Credential mapping**
(`bindings/go/helm/internal/download/download.go`):
- When `password` is not present but `accessToken` is, map the token to
password for basic auth
- Enables token-based authentication with OCI registries like GitHub
Container Registry

## Test plan

- [x] Unit tests added for OCI scheme detection in both input and access
methods
- [x] Existing tests updated to expect `OCIRegistry` type for OCI URLs
- [x] All helm module tests pass
- [x] Linter passes
- [x] compiled the cli with go work and tested it against a private oci
helm chart

Closes open-component-model/ocm-project#967

---------

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/chore chore, maintenance, etc. kind/dependency dependency update, etc. size/xs Extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant