feat(575): regex glob resolver#780
Merged
matthiasbruns merged 16 commits intoSep 5, 2025
Merged
Conversation
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
matthiasbruns
commented
Sep 3, 2025
3512182 to
57cd871
Compare
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
57cd871 to
c0c55f0
Compare
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Contributor
Author
|
Options for glob packages
@jakobmoellerdev I will keep searching for more packages |
Member
|
For such fundamental libraries they are sometimes "feature-complete". In those cases you cannot avoid that they dont have a lot of pushes. Most used least broken is a good principle here :D |
fabianburth
reviewed
Sep 4, 2025
Contributor
|
We could also discuss whether we think the capabilities of https://pkg.go.dev/path?utm_source=chatgpt.com#Match are sufficient for our use case here. |
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
f6986f8 to
286d52d
Compare
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
jakobmoellerdev
requested changes
Sep 5, 2025
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
needs some cleanup, docs and a regeneration, then LGTM for me
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Contributor
Author
Yeah I have seen it - but wasn't sure since it's only for pathing |
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Contributor
Author
|
@jakobmoellerdev regenerated |
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Contributor
Author
|
Decided in the Warroom to stick with sdtlib path instead of an external lib |
afb26a6 to
ee03a4b
Compare
615ed82 to
2614c42
Compare
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
2614c42 to
05ac839
Compare
Contributor
Author
jakobmoellerdev
approved these changes
Sep 5, 2025
matthiasbruns
added a commit
that referenced
this pull request
Sep 12, 2025
#### What this PR does / why we need it In #780 we implemented a new configuration resolver implementation that resolves components with a glob matcher. This PR implement the repository that uses the new matcher - the cli integration will be implemented in a follow up pr #### Which issue(s) this PR fixes Contributes open-component-model/ocm-project#575 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Provide a replacement for fallbackresolvers to reduce resolving time based on glob pattern matching.
This PR focusses on the spec/binding side. The repository will follow afterwards.
Which issue(s) this PR fixes
Fixes: open-component-model/ocm-project#575