feat(dag): dag based construct processing#772
Merged
jakobmoellerdev merged 21 commits intoSep 12, 2025
Merged
Conversation
5e15601 to
87ab879
Compare
fabianburth
commented
Sep 2, 2025
3fd2f65 to
2ed37ec
Compare
5f4a65a to
9777c2c
Compare
Contributor
Author
|
Need to get rid of the replace statement. But besides that, ready for review finally! |
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
This looks great already, mostly beauty nits and polish needed but generally awesome stuff!
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
9777c2c to
142eedb
Compare
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
…ntime Signed-off-by: Fabian Burth <fabian.burth@sap.com>
jakobmoellerdev
previously approved these changes
Sep 12, 2025
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
jakobmoellerdev
approved these changes
Sep 12, 2025
Skarlso
approved these changes
Sep 12, 2025
jakobmoellerdev
pushed a commit
that referenced
this pull request
Sep 17, 2025
…#889) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Follow up to #772. - Pass an external component repository to the construction. This allows to resolve components that are not part of the constructor. This is required to calculate the digest of reference. - Minor adjustments due to breaking API changes to dependent features in the plugins and credential module #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Contributes to open-component-model/ocm-project#564 --------- Signed-off-by: Fabian Burth <fabian.burth@sap.com>
matthiasbruns
pushed a commit
to matthiasbruns/open-component-model
that referenced
this pull request
Sep 18, 2025
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it The current construct implementation processes all the components in a constructor concurrently. Since we want to be able to add the digest of component references to the constructed component descriptors. To even calculate the digest of the referenced component descriptor, that descriptor has to be constructed already. As a conclusion, we need a graph processing logic, where all children are constructed before its parent is being constructed. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> open-component-model/ocm-project#564 --------- Signed-off-by: Fabian Burth <fabian.burth@sap.com>
matthiasbruns
pushed a commit
to matthiasbruns/open-component-model
that referenced
this pull request
Sep 18, 2025
…open-component-model#889) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Follow up to open-component-model#772. - Pass an external component repository to the construction. This allows to resolve components that are not part of the constructor. This is required to calculate the digest of reference. - Minor adjustments due to breaking API changes to dependent features in the plugins and credential module #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Contributes to open-component-model/ocm-project#564 --------- Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The current construct implementation processes all the components in a constructor concurrently. Since we want to be able to add the digest of component references to the constructed component descriptors. To even calculate the digest of the referenced component descriptor, that descriptor has to be constructed already.
As a conclusion, we need a graph processing logic, where all children are constructed before its parent is being constructed.
Which issue(s) this PR fixes
open-component-model/ocm-project#564