feat(oci): use interfaces from repositories module#421
Merged
fabianburth merged 16 commits intoJul 18, 2025
Merged
Conversation
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
7d17e99 to
4d6a5b6
Compare
`localblob` access type no longer has to be registered manually, as it is now registered as part of `v2.MustAddToScheme()` Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Skarlso
reviewed
Jul 17, 2025
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
# Conflicts: # bindings/go/oci/repository.go
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
jakobmoellerdev
approved these changes
Jul 18, 2025
fabianburth
added a commit
that referenced
this pull request
Jul 18, 2025
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it So far, the plugin module and the oci module duplicated the ocm repository interfaces. - In #403, a dedicated module for those ocm repository interfaces was introduced. - In #421, the oci module is adjusted to use those interfaces. This PR adjusts the plugin module to also use those centrally defined ocm repository interfaces. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> --------- Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Related to: #403
This PR added the ocm repository interfaces to a module that is intended to only work on the abstraction level of ocm repositories (and therefore, does not have storage technology specific code) and can be imported by oci.
Which issue(s) this PR fixes