fix(deps): update kubernetes dependencies to v0.36.0#2654
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (70)
✅ Files skipped from review due to trivial changes (59)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughWalkthroughBumps DEEPCOPY_GEN_VERSION to v0.36.0 and regenerates autogenerated deepcopy headers; updates multiple Go module dependency blocks (k8s.io/* → v0.36.0, controller-runtime → v0.24.1, Prometheus/protobuf transitive changes); adjusts controller error-event emissions and status event formatting. ChangesDeepcopy-gen Tool Upgrade and Go Module Dependencies
🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Suggested Reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
kubernetes/controller/go.mod (1)
7-7:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winVerify
opencontainers/go-digestreplace directive target (acc66fb5367c)
acc66fb5367cmatches the published pseudo-version for thegithub.com/opencontainers/go-digest/blake3module (v0.0.0-20260423074420-acc66fb5367c), so the referenced revision appears reachable in upstream.
Couldn’t find a direct source tying that exact revision to PR#66; link the PR/merge evidence (or adjust the comment to remove the PR#66linkage).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@kubernetes/controller/go.mod` at line 7, The replace directive "replace github.com/opencontainers/go-digest => github.com/opencontainers/go-digest v1.0.1-0.20260423074420-acc66fb5367c" references a specific revision but the review comment ties it to PR `#66` without evidence; either add a verification link (commit/PR/merge URL proving that acc66fb5367c corresponds to PR `#66`) next to the replace directive or remove/adjust the PR `#66` mention in the comment so it only states the pseudo-version and that the revision is reachable upstream.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@kubernetes/controller/go.mod`:
- Line 7: The replace directive "replace github.com/opencontainers/go-digest =>
github.com/opencontainers/go-digest v1.0.1-0.20260423074420-acc66fb5367c"
references a specific revision but the review comment ties it to PR `#66` without
evidence; either add a verification link (commit/PR/merge URL proving that
acc66fb5367c corresponds to PR `#66`) next to the replace directive or
remove/adjust the PR `#66` mention in the comment so it only states the
pseudo-version and that the revision is reachable upstream.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 15f77049-11df-4e6e-9eee-f59baa5b72c2
⛔ Files ignored due to path filters (6)
bindings/go/helm/go.sumis excluded by!**/*.sumbindings/go/transfer/go.sumis excluded by!**/*.sumbindings/go/transfer/integration/go.sumis excluded by!**/*.sumcli/go.sumis excluded by!**/*.sumcli/integration/go.sumis excluded by!**/*.sumkubernetes/controller/go.sumis excluded by!**/*.sum
📒 Files selected for processing (66)
.envbindings/go/blob/filesystem/spec/access/v1alpha1/zz_generated.deepcopy.gobindings/go/configuration/extract/v1alpha1/spec/zz_generated.deepcopy.gobindings/go/configuration/filesystem/v1alpha1/spec/zz_generated.deepcopy.gobindings/go/configuration/generic/v1/spec/zz_generated.deepcopy.gobindings/go/configuration/http/v1alpha1/spec/zz_generated.deepcopy.gobindings/go/configuration/ocm/v1/runtime/zz_generated.deepcopy.gobindings/go/configuration/ocm/v1/spec/zz_generated.deepcopy.gobindings/go/configuration/resolvers/v1alpha1/spec/zz_generated.deepcopy.gobindings/go/constructor/runtime/zz_generated.deepcopy.gobindings/go/constructor/spec/v1/zz_generated.deepcopy.gobindings/go/credentials/spec/config/runtime/zz_generated.deepcopy.gobindings/go/credentials/spec/config/v1/zz_generated.deepcopy.gobindings/go/descriptor/runtime/zz_generated.deepcopy.gobindings/go/descriptor/v2/zz_generated.deepcopy.gobindings/go/generator/ocmtypegen/test/zz_generated.deepcopy.gobindings/go/helm/go.modbindings/go/helm/spec/access/v1/zz_generated.deepcopy.gobindings/go/helm/spec/credentials/v1/zz_generated.deepcopy.gobindings/go/helm/spec/identity/v1/zz_generated.deepcopy.gobindings/go/helm/spec/input/v1/zz_generated.deepcopy.gobindings/go/helm/transformation/spec/v1alpha1/zz_generated.deepcopy.gobindings/go/input/dir/spec/v1/zz_generated.deepcopy.gobindings/go/input/file/spec/v1/zz_generated.deepcopy.gobindings/go/input/utf8/spec/v1/zz_generated.deepcopy.gobindings/go/oci/spec/access/v1/zz_generated.deepcopy.gobindings/go/oci/spec/credentials/v1/zz_generated.deepcopy.gobindings/go/oci/spec/identity/v1/zz_generated.deepcopy.gobindings/go/oci/spec/repository/v1/ctf/zz_generated.deepcopy.gobindings/go/oci/spec/repository/v1/oci/zz_generated.deepcopy.gobindings/go/oci/spec/transformation/v1alpha1/zz_generated.deepcopy.gobindings/go/plugin/internal/dummytype/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/contracts/blobtransformer/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/contracts/componentlister/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/contracts/credentials/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/contracts/digestprocessor/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/contracts/input/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/contracts/ocmrepository/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/contracts/resource/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/contracts/signing/v1/zz_generated.deepcopy.gobindings/go/plugin/manager/types/zz_generated.deepcopy.gobindings/go/rsa/signing/v1alpha1/zz_generated.deepcopy.gobindings/go/rsa/spec/credentials/v1/zz_generated.deepcopy.gobindings/go/rsa/spec/identity/v1/zz_generated.deepcopy.gobindings/go/runtime/zz_generated.deepcopy.gobindings/go/sigstore/signing/v1alpha1/zz_generated.deepcopy.gobindings/go/sigstore/spec/credentials/oidcidentitytoken/v1alpha1/zz_generated.deepcopy.gobindings/go/sigstore/spec/credentials/trustedroot/v1alpha1/zz_generated.deepcopy.gobindings/go/sigstore/spec/identity/signer/v1alpha1/zz_generated.deepcopy.gobindings/go/sigstore/spec/identity/verifier/v1alpha1/zz_generated.deepcopy.gobindings/go/transfer/go.modbindings/go/transfer/integration/go.modbindings/go/transfer/internal/zz_generated.deepcopy.gobindings/go/transform/graph/internal/testutils/zz_generated.deepcopy.gobindings/go/transform/spec/v1alpha1/meta/zz_generated.deepcopy.gobindings/go/transform/spec/v1alpha1/zz_generated.deepcopy.gocli/go.modcli/integration/go.modcli/internal/plugin/spec/config/v2alpha1/zz_generated.deepcopy.gocli/internal/versioncheck/zz_generated.deepcopy.gokubernetes/controller/api/v1alpha1/groupversion_info.gokubernetes/controller/go.modkubernetes/controller/internal/controller/component/component_controller.gokubernetes/controller/internal/controller/deployer/deployer_controller.gokubernetes/controller/internal/controller/resource/resource_controller.gokubernetes/controller/internal/status/mutate_condition_status.go
✅ Deploy Preview for ocm-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Actionable comments posted: 0 |
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
8f9d14a to
26f27fd
Compare
10fe102
bddbabd
into
open-component-model:main
…model#2654) #### What this PR does / why we need it Updates the Kubernetes dependency set to v0.36.0, matching the Renovate update from open-component-model#2632, and includes the required follow-up fixes so the update can pass CI. This includes: - Updating Kubernetes modules and related generated-tool version metadata. - Aligning controller-runtime with Kubernetes v0.36.0. - Tidying affected module dependency graphs. - Fixing event recorder format-string vet failures exposed by the updated dependency/toolchain set. #### Which issue(s) this PR fixes Follow-up/replacement for open-component-model#2632. #### Testing ##### How to test the changes Run package-load/compile checks in affected modules: ```bash go test ./... -run ^ ``` Checked in: - `cli` - `cli/integration` - `bindings/go/helm` - `bindings/go/transfer` - `bindings/go/transfer/integration` - `kubernetes/controller` ##### Verification - [ ] I have added/updated tests that prove my fix is effective or that my feature works - [x] Tests pass locally with my changes - [ ] If touching multiple modules, `go work` is enabled (see `go.work`) - [x] My changes do not decrease test coverage - [ ] I have tested the changes locally by running `ocm` Note: controller package compilation was verified with `go test ./... -run ^`. Full envtest suites require local envtest binaries/examples that are not available in this checkout. --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com> bddbabd
#### What this PR does / why we need it Updates the Kubernetes dependency set to v0.36.0, matching the Renovate update from #2632, and includes the required follow-up fixes so the update can pass CI. This includes: - Updating Kubernetes modules and related generated-tool version metadata. - Aligning controller-runtime with Kubernetes v0.36.0. - Tidying affected module dependency graphs. - Fixing event recorder format-string vet failures exposed by the updated dependency/toolchain set. #### Which issue(s) this PR fixes Follow-up/replacement for #2632. #### Testing ##### How to test the changes Run package-load/compile checks in affected modules: ```bash go test ./... -run ^ ``` Checked in: - `cli` - `cli/integration` - `bindings/go/helm` - `bindings/go/transfer` - `bindings/go/transfer/integration` - `kubernetes/controller` ##### Verification - [ ] I have added/updated tests that prove my fix is effective or that my feature works - [x] Tests pass locally with my changes - [ ] If touching multiple modules, `go work` is enabled (see `go.work`) - [x] My changes do not decrease test coverage - [ ] I have tested the changes locally by running `ocm` Note: controller package compilation was verified with `go test ./... -run ^`. Full envtest suites require local envtest binaries/examples that are not available in this checkout. --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com> bddbabd
What this PR does / why we need it
Updates the Kubernetes dependency set to v0.36.0, matching the Renovate update from #2632, and includes the required follow-up fixes so the update can pass CI.
This includes:
Which issue(s) this PR fixes
Follow-up/replacement for #2632.
Testing
How to test the changes
Run package-load/compile checks in affected modules:
go test ./... -run ^Checked in:
clicli/integrationbindings/go/helmbindings/go/transferbindings/go/transfer/integrationkubernetes/controllerVerification
go workis enabled (seego.work)ocmNote: controller package compilation was verified with
go test ./... -run ^. Full envtest suites require local envtest binaries/examples that are not available in this checkout.