feat: 1047 typed credentials - full migration path by jakobmoellerdev · Pull Request #2599 · open-component-model/open-component-model

jakobmoellerdev · 2026-05-21T14:28:41Z

What this PR does / why we need it

This PR basically migrates the whole code-base to the final state of credentials including cli and controllers.

updates all interfaces that used credentials map[string]string
updates plugin boundary auth parsing
updates all consumers and cross references
updates cli & controllers
updates all tests and integration tests
cleans up deprecated consts and helper functions
adds a util to convert runtime.Typed into typed credentials in the bindings where needed
introduces typed credentials in sigstore

Which issue(s) this PR fixes

Contributes:

Binding release order

Dependency graph (changed → changed only):

blob → (none)
signing → (none)
rsa → (none)
sigstore → signing
repository → blob, credentials
oci → blob, credentials, repository
constructor → blob, credentials, oci, repository
plugin → blob, constructor, credentials, repository, signing
input/dir → blob, constructor, credentials, repository
input/file → blob, constructor, credentials, repository
input/utf8 → blob, constructor, credentials, repository
helm → blob, constructor, credentials, oci, plugin, repository
transfer → blob, credentials, helm, oci, repository, signing

PR plan:

Gate	PRs	Modules	Can review in parallel
1	✅ PR 1 (#2580)	blob, signing, rsa	✅ (3 modules)
2	✅ PR 2 (#2586)	repository, sigstore	✅ (2 modules)
3	PR 3 (#2594)	oci	—
4	PR 4 (#2598)	constructor	—
5	PR 5 (#2602)	plugin, input/dir, input/file, input/utf8	✅ (4 modules)
6	PR 6 (#2612)	helm	—
7	PR 7	transfer, controller	✅ (2 modules)
8	PR 8	cli	—

netlify · 2026-05-21T14:28:49Z

❌ Deploy Preview for ocm-website failed. Why did it fail? →

Name	Link
🔨 Latest commit	`3e75ee6`
🔍 Latest deploy log	https://app.netlify.com/projects/ocm-website/deploys/6a0feedc58356f0007f850fe

coderabbitai · 2026-05-21T14:28:52Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 52cd831c-b6b6-4a5c-b6c2-a1b6bacd73e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

… into feat/1043 The branch had merged main mid-way through the credentials map[string]string -> runtime.Typed migration, leaving the Go workspace internally inconsistent and unable to build (cli and kubernetes/controller). Merging open-component-model#2599 ("feat: 1047 typed credentials - full migration path") brings the completed migration so all binding modules agree on the credentials API. Conflicts (all in bindings/go/constructor, migration-only, resolved in favour of open-component-model#2599): - construct.go provider.ResolveTyped -> provider.Resolve - construct_resource_test.go mockCredentialProvider.Resolve returns runtime.Typed - go.mod / go.sum credentials v0.0.11 -> v0.0.12 Verified: `go build ./...` is clean for cli and kubernetes/controller; `go vet` is clean for the bindings/go/oci/integration module. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…credentials (gate 5) (#2602) ## Summary Gate 5 of the typed credentials migration (#1047). Migrates `plugin`, `constructor`, and `input/*` modules from `map[string]string` to `runtime.Typed` credentials. This continues the series started in gates 1-4 (blob, signing, rsa, repository, sigstore, oci, constructor published as PR #2598). ### Modules changed | Module | Change | |--------|--------| | `bindings/go/constructor` | `Resolver.Resolve` return type `map[string]string` → `runtime.Typed`; bump credentials v0.0.11→v0.0.12 | | `bindings/go/input/dir` | `ProcessResource`/`ProcessSource` credentials param `map[string]string` → `runtime.Typed` | | `bindings/go/input/file` | same | | `bindings/go/input/utf8` | same | | `bindings/go/plugin` | All contract interfaces, registry implementations, handlers, converters, test plugins | ### Key design decisions - **Client side** (`toCredentials`): `nil` credentials → sends `"{}"` JSON to preserve valid Authorization header format - **Server side** (handlers): deserialize Authorization header into `&runtime.Raw{}` since concrete type is unknown at HTTP boundary - **`plugin/go.mod`**: uses `replace` directive pointing to local `../constructor` (gate 5 constructor not yet released as module tag) ### Related issues - Part of #1047 (typed credentials migration) - Supersedes draft PR #2599 ## Test plan - [x] `go build ./...` passes in all 5 affected modules - [x] `go test ./...` passes in `constructor`, `input/dir`, `input/file`, `input/utf8` - [x] `go test ./...` passes in `plugin` (96 files changed, all registry/handler/flow tests pass) - [ ] Integration tests with downstream modules (gates 6-8 not yet migrated) --------- Signed-off-by: Jakob Möller <contact@jakob-moeller.com>

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com> # Conflicts: # bindings/go/plugin/manager/registries/componentversionrepository/handlers.go # bindings/go/plugin/manager/registries/componentversionrepository/implementations.go # bindings/go/plugin/manager/registries/componentversionrepository/implementations_test.go # bindings/go/plugin/manager/registries/input/implementations_test.go # bindings/go/plugin/manager/registries/input/registry_test.go # bindings/go/plugin/manager/registries/resource/contract.go # bindings/go/plugin/manager/registries/resource/endpoints_function.go # bindings/go/plugin/manager/registries/resource/implementations.go # bindings/go/plugin/manager/registries/resource/implementations_test.go # bindings/go/plugin/manager/registries/resource/registry_test.go # bindings/go/plugin/manager/registries/signinghandler/handlers_test.go # bindings/go/plugin/manager/registries/signinghandler/implementations.go # bindings/go/plugin/manager/registries/signinghandler/implementations_test.go

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

Update oci module from v0.0.40/v0.0.41 to v0.0.43 in cli, cli/integration, transfer, and helm modules. Also remove intermediate FromDirectCredentials and FromTyped helpers from oci/spec/credentials/v1/oci_credentials.go that referenced deleted symbols; ConvertToOCICredentials in convert.go is the correct public API. On-behalf-of: @SAP <jakob.moeller@sap.com>

github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/l Large labels May 21, 2026

This was referenced May 21, 2026

feat: 1047 typed credentials - full migration path #2519

Closed

feat!: migrate plugin + constructor + input modules to runtime.Typed credentials (gate 5) #2602

Merged

matthiasbruns added 22 commits May 22, 2026 07:39

feat: 1047 credentials phase 3 - consumer impl

68732ee

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: bring back helm spec

839eb03

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: bump credentials in constructor

c199b7a

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: revert credentials to main

0c95975

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: reset examples

15176ca

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: update helm

e10c532

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: update signing to run on typed

2178e73

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

feat: typed digest processor

746638c

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: working on input plugin

5df5456

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

feat: update more interfaces to runtime.Typed

251f67a

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

feat: convert helm to runtime.Typed

5274912

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

feat: add FromTyped

aa9ef11

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: update oci tests

e734b5e

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

fix: tests

71279a7

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

fix: plugin auth boundary

3975bf6

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

feat: typed sigstore

63d6928

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

feat: migrate rsa and cli to typed credentials

1884fca

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

fix: cli tests

fe0afd8

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

feat: migrate controller

9f5286c

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

feat: migrate blobtransformer to runtime.Typed

c8a93ae

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

fix: tests and auth parsing

61e24a7

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

matthiasbruns and others added 7 commits May 22, 2026 07:50

chore: clean up

ce8bf81

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: deprecate snake_care consts

78d9f16

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: roll back not needed credential binding change

86639f7

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: sync rsa

d65f4e7

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: update conversion patterns and rebase main

efc481b

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

chore: sync sigstore

88f0992

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> On-behalf-of: @SAP <jakob.moeller@sap.com>

jakobmoellerdev force-pushed the feat/1047_typed_credentials_phase_3_consumers branch from af0664b to 3e75ee6 Compare May 22, 2026 05:51

jakobmoellerdev closed this May 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 1047 typed credentials - full migration path#2599

feat: 1047 typed credentials - full migration path#2599
jakobmoellerdev wants to merge 29 commits into
open-component-model:mainfrom
jakobmoellerdev:feat/1047_typed_credentials_phase_3_consumers

jakobmoellerdev commented May 21, 2026 •

edited

Loading

Uh oh!

netlify Bot commented May 21, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 21, 2026 •

edited

Loading

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jakobmoellerdev commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Which issue(s) this PR fixes

Binding release order

Uh oh!

netlify Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for ocm-website failed. Why did it fail? →

Uh oh!

coderabbitai Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jakobmoellerdev commented May 21, 2026 •

edited

Loading

netlify Bot commented May 21, 2026 •

edited

Loading

coderabbitai Bot commented May 21, 2026 •

edited

Loading