chore: clarify credential resolution#2446
Conversation
✅ Deploy Preview for ocm-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a subsection to the typed-credentials ADR describing credential resolution across three lookup paths (direct leaf credentials, indirect plugin-backed DAG resolution with ingestion-time cycle rejection, and repository fallback only when the DAG has no match) and appends a 2026-05-05 changelog entry summarizing these mechanics. ChangesTyped credentials ADR
Sequence DiagramssequenceDiagram
participant Ingestor
participant Graph
participant Plugin
participant Repository
Ingestor->>Graph: construct DAG (identities + credential nodes)
Graph->>Plugin: depth-first resolve plugin-backed identity
Plugin->>Graph: return child identities until leaf
Graph->>Graph: detect and reject cycles at ingestion
Graph->>Repository: if DAG has no match -> run repositories concurrently (first success wins)
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
|
Why wasn't the maintainer team requested as reviewers here? |
I have no idea - now I did a request - doesn't that usually happen by repo rules? |
|
I think github is playing tricks on us again, we didnt change any rules. |
dc4599b to
10a5ce6
Compare
|
@matthiasbruns needs a rebase, but still good |
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
efcbc58
8a468ac to
efcbc58
Compare
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
What this PR does / why we need it
Clarification of questions that came up according to how credentials (direct vs indirect) are being resolved.
Which issue(s) this PR fixes
Contributes: open-component-model/ocm-project#702
Contributes: open-component-model/ocm-project#980