Skip to content

chore: table-driven tests as follow-up to #2324#2388

Closed
morri-son wants to merge 2 commits into
open-component-model:mainfrom
morri-son:feat/localblob-uppercamelcase-constructor
Closed

chore: table-driven tests as follow-up to #2324#2388
morri-son wants to merge 2 commits into
open-component-model:mainfrom
morri-son:feat/localblob-uppercamelcase-constructor

Conversation

@morri-son

@morri-son morri-son commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Follow-up to #2324: converts tests to table-driven style.

Which issue(s) this PR fixes

Follow-up #2324

Testing

How to test the changes
task test
Verification
  • I have added/updated tests for my changes (see Test Requirements)
  • Tests pass locally (task test and task test/integration if applicable)
  • If touching multiple modules, go work is enabled (see go.work)
  • My changes do not decrease test coverage
  • I have tested the changes locally by running ocm

@morrison-sap
change to table-driven tests
674d939 
Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
@morri-son morri-son added the kind/chore chore, maintenance, etc. label Apr 24, 2026
@morri-son morri-son requested a review from a team as a code owner April 24, 2026 11:56
@netlify

netlify Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for ocm-website ready!

Name Link
🔨 Latest commit a2703a0
🔍 Latest deploy log https://app.netlify.com/projects/ocm-website/deploys/69eb8691ac17aa0008ffda70
😎 Deploy Preview https://deploy-preview-2388--ocm-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@morri-son has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 48 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 34 minutes and 48 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e817d147-01e1-4831-88a2-3d15534d5a6c

📥 Commits

Reviewing files that changed from the base of the PR and between 367aec2 and a2703a0.

📒 Files selected for processing (2)
  • bindings/go/descriptor/v2/helpers_test.go
  • bindings/go/descriptor/v2/scheme_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/m Medium label Apr 24, 2026
@morri-son morri-son changed the title chore(constructor): table-driven tests as follow-up to #2324 chore: table-driven tests as follow-up to #2324 Apr 24, 2026
@morri-son morri-son enabled auto-merge (squash) April 24, 2026 15:04
piotrjanik
piotrjanik approved these changes Apr 27, 2026
View reviewed changes

@piotrjanik piotrjanik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Apr 27, 2026
@morrison-sap
test(descriptor): table-driven refactor and unversioned unmarshal tes…
8f48d0d 
…ts for LocalBlob

- Add unversioned unmarshal tests for UpperCamelCase and legacy type strings
- Consolidate scheme resolution tests into table-driven TestScheme_ResolvesAllLocalBlobAliases
- Consolidate IsLocalBlob tests into table-driven TestIsLocalBlob
- Remove stale comment in TestLocalBlob_Constants

Combines changes from open-component-model#2323 and open-component-model#2388.

Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
@morri-son morri-son mentioned this pull request Apr 27, 2026
Merged
@morri-son

morri-son commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Absorbed into #2323 — the table-driven IsLocalBlob refactor from this PR has been combined with the scheme and unmarshal test changes there. Single clean commit on a rebased branch.

@morri-son morri-son closed this Apr 27, 2026
auto-merge was automatically disabled April 27, 2026 11:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piotrjanik piotrjanik piotrjanik approved these changes

@fabianburth fabianburth fabianburth approved these changes

Assignees

No one assigned

Labels

kind/chore chore, maintenance, etc. size/m Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morri-son @piotrjanik @fabianburth @morrison-sap