website/static/install-cli.sh (1)

140-151: Optional: /releases pagination may miss the latest stable.

The /releases list endpoint returns 30 entries per page by default, ordered by creation date. If more than 30 pre-releases (-rc.*) are created after the last stable, the most recent stable falls off page 1 and head -1 will find no match, making get_release_version fatal out even though a stable exists.

Low probability today, but trivial to harden:

♻️ Proposed change

-        METADATA_URL="https://api.github.com/repos/${GITHUB_REPO}/releases"
+        METADATA_URL="https://api.github.com/repos/${GITHUB_REPO}/releases?per_page=100"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@website/static/install-cli.sh` around lines 140 - 151, The script can miss
stable releases due to GitHub's paginated /releases endpoint; update the logic
that builds METADATA_URL and computes VERSION_OCM so it paginates through
releases (e.g., request per_page=100 and iterate pages via &page=N until either
a matching stable tag is found or no more results) instead of relying on a
single download to TMP_METADATA and head -1; ensure you reuse TAG_PREFIX and
TMP_METADATA, append or aggregate page responses, and stop the loop when grep
for "\"${TAG_PREFIX}v[0-9]+\.[0-9]+\.[0-9]+\"" yields a match to set
VERSION_OCM, or exit gracefully if none found.

website/static/install-cli-test.sh (2)

312-315: Status capture is unreliable under set -e.

output=$(verify_binary 2>&1) runs under set -euo pipefail. If verify_binary ever returns non-zero (e.g., a regression where the early-return guard is removed), the harness aborts immediately and local status=$? never executes — so a real regression would crash the harness rather than fail the assertion. The other fatal-path tests already use the safer (...) || status=$? form (Lines 134, 158, 182, 200, 293); please apply the same pattern here and in test_verify_skips_when_gh_not_authenticated (Lines 331-334).

♻️ Suggested change

-    local output
-    output=$(verify_binary 2>&1)
-    local status=$?
+    local status=0
+    verify_binary >/dev/null 2>&1 || status=$?
     assert_equals "verify_binary returns 0 when gh missing" "0" "${status}"

(and analogously at Lines 331-334 and 348-351)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@website/static/install-cli-test.sh` around lines 312 - 315, The test captures
return status unreliably because output=$(verify_binary 2>&1) runs under set -e
and will abort on non-zero; change the capture to run the command in a subshell
and record the exit code using the safe pattern ( ... ) || status=$? so the
harness doesn't exit early; update the verify_binary invocation in this block
(where output and status are set) and do the same change in the related test
test_verify_skips_when_gh_not_authenticated to use (verify_binary 2>&1) ||
status=$? and then assign output from the subshell capture so assertions can run
reliably.

---

309-319: Mock cleanup not exception-safe.

unset -f command (Line 317) and unset -f gh (Line 336) only run if the prior assertions/commands all succeed under set -e. A future change that causes an early non-zero exit would leak these function overrides into subsequent tests, producing confusing cascading failures (e.g., a stubbed command or gh affecting later tests). Consider a per-test trap '...' RETURN (or a small cleanup helper invoked via trap) to guarantee restoration of the global state and removal of tmpdir.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@website/static/install-cli-test.sh` around lines 309 - 319, The test
temporarily overrides the shell functions/commands `command` and `gh` and
removes `tmpdir` but restores them only on the success path; make the cleanup
exception-safe by adding a per-test trap that always runs on function RETURN (or
use a small `cleanup` helper and trap it), e.g. register a trap at the start of
the test to unset the overridden functions (`unset -f command` and `unset -f
gh`) and remove `${tmpdir}` regardless of failures; ensure the trap references
the same identifiers used in the test (verify_binary, command, gh, tmpdir) so
restoration runs even if `set -e` causes an early exit.