chore: apply to the website add tutorial for PEM signing with certificate chains#2270
Conversation
…cate chains On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
✅ Deploy Preview for ocm-website canceled.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 41 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughReorganizes signing/verification docs into a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@website/content/docs/tutorials/signing/pem.md`:
- Around line 549-551: The troubleshooting section currently runs the command
"openssl verify -CAfile root.crt -untrusted intermediate.crt leaf.crt"
unconditionally which breaks Option A (where intermediate.crt is not created);
change the doc so that the second verification is executed only if an
intermediate certificate exists — either by adding a short conditional note
instructing users to run that command only when they followed Option B (or the
intermediate file is present) or by replacing the unconditional command with a
sentence that says "If you created intermediate.crt (Option B), run: openssl
verify -CAfile root.crt -untrusted intermediate.crt leaf.crt" so readers
following Option A won't see a failing command.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 776ff61d-3717-483a-bd47-09e16ddc2db6
📒 Files selected for processing (14)
website/assets/scss/common/_sidebar.scsswebsite/content/_index.mdwebsite/content/docs/concepts/signing-and-verification-concept.mdwebsite/content/docs/concepts/transfer-concept.mdwebsite/content/docs/how-to/air-gap-transfer.mdwebsite/content/docs/how-to/generate-signing-keys.mdwebsite/content/docs/how-to/sign-component-version.mdwebsite/content/docs/how-to/verify-component-version.mdwebsite/content/docs/tutorials/advanced-component-constructor.mdwebsite/content/docs/tutorials/configure-resolvers.mdwebsite/content/docs/tutorials/signing/_index.mdwebsite/content/docs/tutorials/signing/pem.mdwebsite/content/docs/tutorials/signing/plain.mdwebsite/layouts/_partials/sidebar/render-section-menu.html
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
f69cf13 to
04846e2
Compare
|
Linkchecker now correctly only runs on modified stuff and the repo checker doesn't run on website stuff. Nice. Worked Repo: |
…cate chains (#2270) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This is a 1:1 port over from the website pull request here open-component-model/ocm-website#795 into the monorepo. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### Testing ##### How to test the changes <!-- Required files to test the changes: .ocmconfig ```yaml type: generic.config.ocm.software/v1 configurations: - type: credentials.config.ocm.software repositories: - repository: type: DockerConfig/v1 dockerConfigFile: "~/.docker/config.json" ``` Commands that test the change: ```bash ocm get cv xxx ocm transfer xxx ``` --> ##### Verification - [ ] I have tested the changes locally by running `ocm` --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> cec9ee3
…cate chains (open-component-model#2270) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This is a 1:1 port over from the website pull request here open-component-model/ocm-website#795 into the monorepo. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### Testing ##### How to test the changes <!-- Required files to test the changes: .ocmconfig ```yaml type: generic.config.ocm.software/v1 configurations: - type: credentials.config.ocm.software repositories: - repository: type: DockerConfig/v1 dockerConfigFile: "~/.docker/config.json" ``` Commands that test the change: ```bash ocm get cv xxx ocm transfer xxx ``` --> ##### Verification - [ ] I have tested the changes locally by running `ocm` --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
…cate chains (open-component-model#2270) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This is a 1:1 port over from the website pull request here open-component-model/ocm-website#795 into the monorepo. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### Testing ##### How to test the changes <!-- Required files to test the changes: .ocmconfig ```yaml type: generic.config.ocm.software/v1 configurations: - type: credentials.config.ocm.software repositories: - repository: type: DockerConfig/v1 dockerConfigFile: "~/.docker/config.json" ``` Commands that test the change: ```bash ocm get cv xxx ocm transfer xxx ``` --> ##### Verification - [ ] I have tested the changes locally by running `ocm` --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
…cate chains (open-component-model#2270) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This is a 1:1 port over from the website pull request here open-component-model/ocm-website#795 into the monorepo. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### Testing ##### How to test the changes <!-- Required files to test the changes: .ocmconfig ```yaml type: generic.config.ocm.software/v1 configurations: - type: credentials.config.ocm.software repositories: - repository: type: DockerConfig/v1 dockerConfigFile: "~/.docker/config.json" ``` Commands that test the change: ```bash ocm get cv xxx ocm transfer xxx ``` --> ##### Verification - [ ] I have tested the changes locally by running `ocm` --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
What this PR does / why we need it
This is a 1:1 port over from the website pull request here open-component-model/ocm-website#795 into the monorepo.
Which issue(s) this PR fixes
Testing
How to test the changes
Verification
ocm