Skip to content

chore: port over add governance page and person card component#2269

Merged
jakobmoellerdev merged 4 commits into
open-component-model:mainfrom
Skarlso:migrate-website-stuff
Apr 13, 2026
Merged

chore: port over add governance page and person card component#2269
jakobmoellerdev merged 4 commits into
open-component-model:mainfrom
Skarlso:migrate-website-stuff

Conversation

@Skarlso

@Skarlso Skarlso commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Port over the governance pull request content from here: open-component-model/ocm-website#796

Which issue(s) this PR fixes

Testing

How to test the changes
Verification
  • I have tested the changes locally by running ocm

@Skarlso Skarlso requested a review from a team as a code owner April 13, 2026 08:00
@netlify

netlify Bot commented Apr 13, 2026

Copy link
Copy Markdown

Deploy Preview for ocm-website ready!

Name Link
🔨 Latest commit 88f7892
🔍 Latest deploy log https://app.netlify.com/projects/ocm-website/deploys/69dcc50379b38e00098f6adc
😎 Deploy Preview https://deploy-preview-2269--ocm-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added kind/chore chore, maintenance, etc. size/m Medium labels Apr 13, 2026
@coderabbitai

coderabbitai Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d6dc2ccc-d785-4649-9618-20fadaaba41a

📥 Commits

Reviewing files that changed from the base of the PR and between 0d41ccd and 420ce94.

📒 Files selected for processing (6)
  • .github/config/wordlist.txt
  • website/assets/scss/common/_cards.scss
  • website/config/_default/menus/menus.en.toml
  • website/content/community/community.md
  • website/content/governance/_index.md
  • website/layouts/shortcodes/person-card.html
✅ Files skipped from review due to trivial changes (3)
  • website/content/community/community.md
  • website/config/_default/menus/menus.en.toml
  • website/content/governance/_index.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • website/assets/scss/common/_cards.scss

📝 Walkthrough

Walkthrough

This PR adds a Governance section to the website: a governance landing page and menu entry, updates the community page to reference the governance page, introduces a person-card Hugo shortcode and corresponding SCSS styles, and updates the repository wordlist.

Changes

Cohort / File(s) Summary
Styling & Shortcodes
website/assets/scss/common/_cards.scss, website/layouts/shortcodes/person-card.html
Added person-card SCSS classes (.person-card, .person-card-inner, .person-card-avatar, .person-card-name, .person-card-role, .person-card-company, .person-section-grid) with responsive layout; added Hugo person-card shortcode rendering avatar, name, role, optional company, and external profile link.
Navigation
website/config/_default/menus/menus.en.toml
Added [[main]] menu item name = "Governance", url = "governance/", weight = 25.
Content / Documentation
website/content/governance/_index.md, website/content/community/community.md
Added new governance landing page with TSC and SIG (including SIG Runtime) documentation; simplified community SIG section to point to /governance/.
Repository config
.github/config/wordlist.txt
Reordered and updated wordlist entries: many tokens added, moved, or deduplicated (content-only change).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

area/documentation

Suggested Reviewers

  • frewilhelm
  • jakobmoellerdev
  • morri-son

Poem

🐇 I nibble on markup, styles in a row,
Cards for our people now ready to show,
Governance pages, a menu to find,
Sig chairs and TSC neatly outlined,
Hooray — a tiny rabbit's celebratory hop!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: adding a governance page and person card component to the website.
Description check ✅ Passed The description relates to the changeset by referencing the governance PR being ported, though it lacks specific details about the actual changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Skarlso Skarlso force-pushed the migrate-website-stuff branch from 5058d6b to 0d41ccd Compare April 13, 2026 08:02
frewilhelm
frewilhelm previously approved these changes Apr 13, 2026
@github-actions github-actions Bot added the component/github-actions Changes on GitHub Actions or within `.github/` directory label Apr 13, 2026
Comment thread .github/config/wordlist.txt

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@website/layouts/shortcodes/person-card.html`:
- Around line 1-7: Add fail-fast validation for required shortcode params by
using Hugo's required helper on .Get values: replace the direct assignments for
$name, $role, $github, and $profile with required calls (e.g., $name := required
"person-card shortcode: missing 'name' parameter" (.Get "name")) so the build
fails with a clear error when any of those params are absent; keep $profileUrl
and $avatarUrl generation unchanged after validation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f4bdb4c5-59fd-4826-9fbc-3ef5c11adf21

📥 Commits

Reviewing files that changed from the base of the PR and between 5058d6b and 0d41ccd.

📒 Files selected for processing (6)
  • .github/config/wordlist.txt
  • website/assets/scss/common/_cards.scss
  • website/config/_default/menus/menus.en.toml
  • website/content/community/community.md
  • website/content/governance/_index.md
  • website/layouts/shortcodes/person-card.html
✅ Files skipped from review due to trivial changes (3)
  • website/config/_default/menus/menus.en.toml
  • website/assets/scss/common/_cards.scss
  • website/content/governance/_index.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • website/content/community/community.md

Comment thread website/layouts/shortcodes/person-card.html
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso and others added 2 commits April 13, 2026 11:46
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@jakobmoellerdev jakobmoellerdev merged commit 3744aa7 into open-component-model:main Apr 13, 2026
25 checks passed
ocmbot Bot pushed a commit that referenced this pull request Apr 13, 2026
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

Port over the governance pull request content from here:
open-component-model/ocm-website#796

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

#### Testing

##### How to test the changes

<!--
Required files to test the changes:

.ocmconfig
```yaml
type: generic.config.ocm.software/v1
configurations:
  - type: credentials.config.ocm.software
    repositories:
      - repository:
          type: DockerConfig/v1
          dockerConfigFile: "~/.docker/config.json"
```

Commands that test the change:

```bash
ocm get cv xxx

ocm transfer xxx
```
-->

##### Verification

- [ ] I have tested the changes locally by running `ocm`

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> 3744aa7
morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Apr 14, 2026
…component-model#2269)

<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

Port over the governance pull request content from here:
open-component-model/ocm-website#796

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

#### Testing

##### How to test the changes

<!--
Required files to test the changes:

.ocmconfig
```yaml
type: generic.config.ocm.software/v1
configurations:
  - type: credentials.config.ocm.software
    repositories:
      - repository:
          type: DockerConfig/v1
          dockerConfigFile: "~/.docker/config.json"
```

Commands that test the change:

```bash
ocm get cv xxx

ocm transfer xxx
```
-->

##### Verification

- [ ] I have tested the changes locally by running `ocm`

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Apr 14, 2026
…component-model#2269)

<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

Port over the governance pull request content from here:
open-component-model/ocm-website#796

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

#### Testing

##### How to test the changes

<!--
Required files to test the changes:

.ocmconfig
```yaml
type: generic.config.ocm.software/v1
configurations:
  - type: credentials.config.ocm.software
    repositories:
      - repository:
          type: DockerConfig/v1
          dockerConfigFile: "~/.docker/config.json"
```

Commands that test the change:

```bash
ocm get cv xxx

ocm transfer xxx
```
-->

##### Verification

- [ ] I have tested the changes locally by running `ocm`

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Apr 15, 2026
…component-model#2269)

<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

Port over the governance pull request content from here:
open-component-model/ocm-website#796

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

#### Testing

##### How to test the changes

<!--
Required files to test the changes:

.ocmconfig
```yaml
type: generic.config.ocm.software/v1
configurations:
  - type: credentials.config.ocm.software
    repositories:
      - repository:
          type: DockerConfig/v1
          dockerConfigFile: "~/.docker/config.json"
```

Commands that test the change:

```bash
ocm get cv xxx

ocm transfer xxx
```
-->

##### Verification

- [ ] I have tested the changes locally by running `ocm`

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/github-actions Changes on GitHub Actions or within `.github/` directory kind/chore chore, maintenance, etc. size/m Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants