chore: port over add governance page and person card component#2269
Conversation
✅ Deploy Preview for ocm-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a Governance section to the website: a governance landing page and menu entry, updates the community page to reference the governance page, introduces a person-card Hugo shortcode and corresponding SCSS styles, and updates the repository wordlist. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5058d6b to
0d41ccd
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@website/layouts/shortcodes/person-card.html`:
- Around line 1-7: Add fail-fast validation for required shortcode params by
using Hugo's required helper on .Get values: replace the direct assignments for
$name, $role, $github, and $profile with required calls (e.g., $name := required
"person-card shortcode: missing 'name' parameter" (.Get "name")) so the build
fails with a clear error when any of those params are absent; keep $profileUrl
and $avatarUrl generation unchanged after validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f4bdb4c5-59fd-4826-9fbc-3ef5c11adf21
📒 Files selected for processing (6)
.github/config/wordlist.txtwebsite/assets/scss/common/_cards.scsswebsite/config/_default/menus/menus.en.tomlwebsite/content/community/community.mdwebsite/content/governance/_index.mdwebsite/layouts/shortcodes/person-card.html
✅ Files skipped from review due to trivial changes (3)
- website/config/_default/menus/menus.en.toml
- website/assets/scss/common/_cards.scss
- website/content/governance/_index.md
🚧 Files skipped from review as they are similar to previous changes (1)
- website/content/community/community.md
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
0d41ccd to
e3cb9d3
Compare
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Port over the governance pull request content from here: open-component-model/ocm-website#796 #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### Testing ##### How to test the changes <!-- Required files to test the changes: .ocmconfig ```yaml type: generic.config.ocm.software/v1 configurations: - type: credentials.config.ocm.software repositories: - repository: type: DockerConfig/v1 dockerConfigFile: "~/.docker/config.json" ``` Commands that test the change: ```bash ocm get cv xxx ocm transfer xxx ``` --> ##### Verification - [ ] I have tested the changes locally by running `ocm` --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> 3744aa7
…component-model#2269) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Port over the governance pull request content from here: open-component-model/ocm-website#796 #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### Testing ##### How to test the changes <!-- Required files to test the changes: .ocmconfig ```yaml type: generic.config.ocm.software/v1 configurations: - type: credentials.config.ocm.software repositories: - repository: type: DockerConfig/v1 dockerConfigFile: "~/.docker/config.json" ``` Commands that test the change: ```bash ocm get cv xxx ocm transfer xxx ``` --> ##### Verification - [ ] I have tested the changes locally by running `ocm` --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
…component-model#2269) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Port over the governance pull request content from here: open-component-model/ocm-website#796 #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### Testing ##### How to test the changes <!-- Required files to test the changes: .ocmconfig ```yaml type: generic.config.ocm.software/v1 configurations: - type: credentials.config.ocm.software repositories: - repository: type: DockerConfig/v1 dockerConfigFile: "~/.docker/config.json" ``` Commands that test the change: ```bash ocm get cv xxx ocm transfer xxx ``` --> ##### Verification - [ ] I have tested the changes locally by running `ocm` --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
…component-model#2269) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Port over the governance pull request content from here: open-component-model/ocm-website#796 #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### Testing ##### How to test the changes <!-- Required files to test the changes: .ocmconfig ```yaml type: generic.config.ocm.software/v1 configurations: - type: credentials.config.ocm.software repositories: - repository: type: DockerConfig/v1 dockerConfigFile: "~/.docker/config.json" ``` Commands that test the change: ```bash ocm get cv xxx ocm transfer xxx ``` --> ##### Verification - [ ] I have tested the changes locally by running `ocm` --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
What this PR does / why we need it
Port over the governance pull request content from here: open-component-model/ocm-website#796
Which issue(s) this PR fixes
Testing
How to test the changes
Verification
ocm