fix(deps): update ocm monorepo go module dependencies (no ctf)#2174
Conversation
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates OCM-related Go module versions across multiple Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bindings/go/oci/integration/go.mod`:
- Line 16: Update the module version pin in bindings/go/oci/integration/go.mod
so the ctf dependency matches the main binding; change the
ocm.software/open-component-model/bindings/go/ctf entry (currently v0.4.0) to
v0.3.0 to align with bindings/go/oci/go.mod and keep versions consistent across
the bindings.
In `@bindings/go/transfer/integration/go.mod`:
- Line 14: Update the version of the ctf module in the go.mod entry for
ocm.software/open-component-model/bindings/go/ctf from v0.4.0 back to v0.3.0 so
it matches the main branch; edit the dependency line in
bindings/go/transfer/integration/go.mod to reference
ocm.software/open-component-model/bindings/go/ctf v0.3.0 and run go mod tidy to
verify there are no module resolution issues.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c5c97d9b-a433-42bc-b592-109c34bb0789
⛔ Files ignored due to path filters (18)
bindings/go/constructor/go.sumis excluded by!**/*.sumbindings/go/descriptor/normalisation/go.sumis excluded by!**/*.sumbindings/go/helm/go.sumis excluded by!**/*.sumbindings/go/input/dir/go.sumis excluded by!**/*.sumbindings/go/input/file/go.sumis excluded by!**/*.sumbindings/go/input/utf8/go.sumis excluded by!**/*.sumbindings/go/oci/go.sumis excluded by!**/*.sumbindings/go/oci/integration/go.sumis excluded by!**/*.sumbindings/go/plugin/go.sumis excluded by!**/*.sumbindings/go/repository/go.sumis excluded by!**/*.sumbindings/go/rsa/go.sumis excluded by!**/*.sumbindings/go/signing/go.sumis excluded by!**/*.sumbindings/go/transfer/go.sumis excluded by!**/*.sumbindings/go/transfer/integration/go.sumis excluded by!**/*.sumbindings/go/transform/go.sumis excluded by!**/*.sumcli/go.sumis excluded by!**/*.sumcli/integration/go.sumis excluded by!**/*.sumkubernetes/controller/go.sumis excluded by!**/*.sum
📒 Files selected for processing (18)
bindings/go/constructor/go.modbindings/go/descriptor/normalisation/go.modbindings/go/helm/go.modbindings/go/input/dir/go.modbindings/go/input/file/go.modbindings/go/input/utf8/go.modbindings/go/oci/go.modbindings/go/oci/integration/go.modbindings/go/plugin/go.modbindings/go/repository/go.modbindings/go/rsa/go.modbindings/go/signing/go.modbindings/go/transfer/go.modbindings/go/transfer/integration/go.modbindings/go/transform/go.modcli/go.modcli/integration/go.modkubernetes/controller/go.mod
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
992ddb4
This reverts commit 8f78457. Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
❌ Deploy Preview for ocm-website failed. Why did it fail? →
|
…component-model#2174) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it open-component-model@e2b46f9 introduced a change in `ocm.software/open-component-model/bindings/go/ctf v0.4.0` that [breaks tests](https://github.com/open-component-model/open-component-model/actions/runs/24078003573/job/70231212198?pr=2152) in `bindings/go/oci/ctf`. A [fix](open-component-model#2049) is already in progress but it includes a bigger implementation that is not ready to merge yet. This is why, this PR reverts the version bump for that module for now. #### Which issue(s) this PR fixes Fixes open-component-model#2152 #### Testing Run `task test` and `task test/integration` --------- Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com> Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
…component-model#2174) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it open-component-model@e2b46f9 introduced a change in `ocm.software/open-component-model/bindings/go/ctf v0.4.0` that [breaks tests](https://github.com/open-component-model/open-component-model/actions/runs/24078003573/job/70231212198?pr=2152) in `bindings/go/oci/ctf`. A [fix](open-component-model#2049) is already in progress but it includes a bigger implementation that is not ready to merge yet. This is why, this PR reverts the version bump for that module for now. #### Which issue(s) this PR fixes Fixes open-component-model#2152 #### Testing Run `task test` and `task test/integration` --------- Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com> Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
What this PR does / why we need it
e2b46f9 introduced a change in
ocm.software/open-component-model/bindings/go/ctf v0.4.0that breaks tests inbindings/go/oci/ctf. A fix is already in progress but it includes a bigger implementation that is not ready to merge yet. This is why, this PR reverts the version bump for that module for now.Which issue(s) this PR fixes
Fixes #2152
Testing
Run
task testandtask test/integration