Skip to content

feat: register helm digest processor plugin#2076

Merged
jakobmoellerdev merged 3 commits into
open-component-model:mainfrom
jakobmoellerdev:digest-processor-helm
Mar 26, 2026
Merged

feat: register helm digest processor plugin#2076
jakobmoellerdev merged 3 commits into
open-component-model:mainfrom
jakobmoellerdev:digest-processor-helm

Conversation

@jakobmoellerdev

@jakobmoellerdev jakobmoellerdev commented Mar 26, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it

adds the digest processor for helm to cli and controllers

Which issue(s) this PR fixes

allows adding cvs with helm chart accesses without skip reference processing

Testing

ocm add cv

with any helm chart access (see integration test)

Verification
  • I have tested the changes locally by running ocm

@coderabbitai

coderabbitai Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR adds integration and registration of a Helm digest processor plugin across the CLI and Kubernetes controller. It includes an integration test verifying digest processing in component versions, registers the plugin in startup routines, updates indirect dependencies, and applies minor formatting adjustments.

Changes

Cohort / File(s) Summary
Helm Digest Processor Integration Test
cli/integration/add_component_version_integration_test.go		 New integration test Test_Integration_HelmAccess_DigestProcessor that sets up a local HTTP server, creates a Helm chart component version via CLI, and verifies the stored resource digest matches the expected SHA-256 value from the server index.
Plugin Registration
cli/internal/plugin/builtin/builtin.go, kubernetes/controller/cmd/main.go		 Registers Helm digest processor plugin during initialization in both the CLI and Kubernetes controller, with error handling for failed registration.
Dependency Management
kubernetes/controller/go.mod		 Expanded indirect dependencies to include Helm, Kubernetes CLI runtime, and OCI-related packages required for digest processor functionality.
Code Formatting
kubernetes/controller/internal/controller/deployer/suite_test.go		 Whitespace alignment adjustment in Reconciler struct initialization without functional changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

size/l

Suggested reviewers

  • frewilhelm
  • morri-son

Poem

🐰 A Helm chart digest, so shiny and new,
Gets registered with plugins, not one but two!
From CLI to controller, the plugin takes flight,
With tests to ensure every digest is right. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: register helm digest processor plugin' directly and clearly describes the main change: registering a Helm digest processor plugin in both CLI and controllers.
Description check ✅ Passed The description explains that the PR adds a digest processor for Helm to CLI and controllers, enabling adding CVs with Helm chart accesses without skipping reference processing, which aligns with the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/m Medium labels Mar 26, 2026
@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner March 26, 2026 12:13
@jakobmoellerdev
feat: register helm digest processor plugin
d0fb5ab 
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
matthiasbruns
matthiasbruns reviewed Mar 26, 2026
View reviewed changes
Comment thread kubernetes/controller/cmd/main.go
@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) March 26, 2026 14:51
@jakobmoellerdev jakobmoellerdev merged commit 02846d6 into open-component-model:main Mar 26, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasbruns matthiasbruns matthiasbruns approved these changes

@frewilhelm frewilhelm frewilhelm approved these changes

Assignees

No one assigned

Labels

kind/feature new feature, enhancement, improvement, extension size/m Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakobmoellerdev @matthiasbruns @frewilhelm