bindings/go/helm/digest/digest_test.go (2)

260-277: Integration test relies on external resource stability.

The hardcoded digest assertion will fail if Grafana ever republishes grafana:8.8.2 with a different digest. Consider adding a comment noting this dependency, or verify only that the digest fields are populated without asserting the exact value.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/helm/digest/digest_test.go` around lines 260 - 277, The
integration test TestProcessResourceDigest_RealRepo currently asserts a fixed
digest value which can break if the external Grafana chart is republished;
update the test to avoid asserting the exact digest string and instead verify
that ProcessResourceDigest (on digest.NewDigestProcessor) returns a non-nil
result with result.Digest populated and that result.Digest.HashAlgorithm and
result.Digest.NormalisationAlgorithm are non-empty (or match expected algorithm
names if stable), and add a comment above TestProcessResourceDigest_RealRepo
explaining the test depends on an external repo and may be brittle in CI;
alternatively mark it as an external-only/integration test by skipping in CI
environments.

---

1-16: Consider adding test coverage for OCI registry resolution.

The test suite covers HTTP/S repositories comprehensively, but there are no tests for the oci:// code path. Consider adding tests using a mock OCI registry or at least a real-repo integration test similar to TestProcessResourceDigest_RealRepo.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/helm/digest/digest_test.go` around lines 1 - 16, Add test
coverage for the OCI registry code path by creating a new test in digest_test.go
(e.g., TestProcessResourceDigest_OCI) that mirrors
TestProcessResourceDigest_RealRepo but targets an oci:// reference; either mock
an OCI registry endpoint or use a real OCI repo setup and resolve via the digest
package's resolver/ProcessResourceDigest logic to assert correct digest
resolution and error handling. Ensure the test imports/uses the same helpers and
runtime setup as TestProcessResourceDigest_RealRepo, exercises the oci:// URL
path, and asserts expected digest values or failure modes using require/assert.

bindings/go/helm/digest/digest.go (1)

274-276: Error message has reversed semantics.

The error says "expected %s, got %s" with target.Value (the existing digest) as "expected" and d.Encoded() (the resolved digest) as "got". From the verification perspective, the resolved digest is what we expect the resource to have.

✏️ Suggested fix

 	if target.Value != d.Encoded() {
-		return fmt.Errorf("digest value mismatch: expected %s, got %s", target.Value, d.Encoded())
+		return fmt.Errorf("digest value mismatch: resolved %s, but resource has %s", d.Encoded(), target.Value)
 	}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/helm/digest/digest.go` around lines 274 - 276, The error message
in the comparison using fmt.Errorf has reversed semantics: when target.Value !=
d.Encoded() the resolved digest (d.Encoded()) is what we expect, and
target.Value is the current/actual value; update the fmt.Errorf call (the one
comparing target.Value and d.Encoded()) so the format arguments are swapped and
read "expected %s, got %s" with d.Encoded() as the expected value and
target.Value as the got/actual value so the message correctly reports expected
(d.Encoded()) vs actual (target.Value).