bindings/go/helm/input/method.go (1)

32-33: Add alias-conversion coverage tests for Helm + helm.

These registrations are correct; adding table-driven tests for versioned and unversioned conversions (Helm, helm) will lock in backward compatibility for future refactors.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/helm/input/method.go` around lines 32 - 33, Add table-driven unit
tests that exercise alias-conversion for both the versioned and unversioned
registrations of the Helm type (i.e., the "Helm" and "helm" aliases) to ensure
backward compatibility; specifically, create tests that register
runtime.NewVersionedType(v1.LegacyType, v1.Version) and
runtime.NewUnversionedType(v1.LegacyType) conversions and assert round-trip
conversions between the alias names and the canonical type, covering both
input->internal and internal->output paths so future refactors cannot break
alias handling.

bindings/go/helm/input/method_test.go (1)

294-298: Add a legacy-alias scheme assertion in this test.

This covers Helm/v1, but the PR goal also includes backward-compatible lowercase aliases. Please also assert v1.LegacyType resolution (helm/v1) to prevent alias-regression gaps.

Proposed test extension

 func TestScheme_ResolvesUpperCamelCase_Helm(t *testing.T) {
 	obj, err := input.Scheme.NewObject(runtime.NewVersionedType(v1.Type, v1.Version))
 	require.NoError(t, err, "Scheme must resolve UpperCamelCase type Helm/v1")
 	require.IsType(t, &v1.Helm{}, obj, "expected *v1.Helm from Scheme")
+
+	legacyObj, err := input.Scheme.NewObject(runtime.NewVersionedType(v1.LegacyType, v1.Version))
+	require.NoError(t, err, "Scheme must resolve legacy type helm/v1")
+	require.IsType(t, &v1.Helm{}, legacyObj, "expected *v1.Helm from Scheme for legacy type")
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/helm/input/method_test.go` around lines 294 - 298, The test
TestScheme_ResolvesUpperCamelCase_Helm currently asserts resolution for the
UpperCamelCase type Helm/v1 but lacks coverage for the lowercase legacy alias;
add a second assertion that calls input.Scheme.NewObject with
runtime.NewVersionedType(v1.LegacyType, v1.Version) (i.e., "helm"/v1) and verify
it returns no error and an object of type *v1.Helm using require.NoError and
require.IsType, mirroring the existing assertions to prevent alias-regression.

cli/cmd/cmd_test.go (1)

829-829: Consider centralizing the LocalBlob/v1 test literal.

The same literal appears in multiple places; deriving it from constants would reduce drift in future renames.

♻️ Optional refactor sketch

+expectedLocalBlobType := descriptor.LocalBlobAccessType + "/" + descriptor.LocalBlobAccessTypeVersion
...
- r.Equal("LocalBlob/v1", desc.Component.Resources[0].Access.GetType().String(), "expected resource access type to match")
+ r.Equal(expectedLocalBlobType, desc.Component.Resources[0].Access.GetType().String(), "expected resource access type to match")

Also applies to: 1240-1240, 1353-1353, 1777-1777, 1817-1817

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cli/cmd/cmd_test.go` at line 829, Replace repeated string literal
"LocalBlob/v1" used in the test assertions with a single shared constant; update
the r.Equal assertions that compare
desc.Component.Resources[0].Access.GetType().String() (and the other occurrences
at the noted locations) to use that constant (e.g., ExpectedLocalBlobType or
TestLocalBlobType) so future renames only require changing the constant; if a
canonical constant already exists in the codebase prefer importing/using that
symbol instead of creating a new one.

bindings/go/descriptor/v2/local_access_test.go (1)

101-105: Add direct JSON unmarshal coverage for LocalBlob/v1.

You already validate scheme resolution for UpperCamelCase; adding a direct json.Unmarshal case for "type":"LocalBlob/v1" would close the remaining gap.

✅ Suggested test addition

+func TestLocalBlob_UnmarshalJSON_UpperCamelCase(t *testing.T) {
+	jsonData := `{
+		"type": "LocalBlob/v1",
+		"localReference": "sha256:abc123",
+		"mediaType": "application/octet-stream"
+	}`
+
+	var blob descriptorv2.LocalBlob
+	err := json.Unmarshal([]byte(jsonData), &blob)
+
+	require.NoError(t, err)
+	assert.Equal(t, descriptorv2.LocalBlobAccessType, blob.Type.Name)
+	assert.Equal(t, descriptorv2.LocalBlobAccessTypeVersion, blob.Type.Version)
+}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/descriptor/v2/local_access_test.go` around lines 101 - 105, Add a
new unit test (e.g., TestScheme_Unmarshal_LocalBlob_v1) that constructs a JSON
payload with "type":"LocalBlob/v1" (and minimal required fields), performs a
direct json.Unmarshal of that payload into the runtime/object representation
used by your bindings, and asserts the resulting concrete type is
*descriptorv2.LocalBlob; this mirrors
TestScheme_ResolvesUpperCamelCase_LocalBlob but exercises the plain JSON
unmarshal path to ensure "LocalBlob/v1" deserializes to descriptorv2.LocalBlob.

cli/cmd/type_casing_test.go (2)

194-195: Add an explicit precondition check for Helm testdata path.

filepath.Abs(...) only validates path formatting, not existence. If the fixture moves, failure will occur later in ocm add cv with a less direct error. A require.DirExists (or equivalent) here would make failures immediate and clearer.

Also applies to: 221-223

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cli/cmd/type_casing_test.go` around lines 194 - 195, Add an explicit
directory existence assertion after resolving the absolute path so test failures
are immediate and clear: after computing chartDir with filepath.Abs in the test
(the chartDir, err := filepath.Abs(...) / require.NoError(t, err) block), call
require.DirExists(t, chartDir) (or equivalent) to ensure the Helm testdata
directory actually exists; repeat the same check for the other instance
referenced around the second occurrence (lines 221-223).

---

291-300: Avoid brittle success checks based on log text.

At Line 295, asserting "transfer completed successfully" via substring is fragile and can break on message wording changes while behavior is still correct. Exit status plus the target CTF assertions already provide strong success validation.

Suggested simplification

-			// Verify transfer logs contain success
-			transferEntries, err := transferLogs.List()
-			r.NoError(err)
-			found := false
-			for _, entry := range transferEntries {
-				if strings.Contains(fmt.Sprint(entry), "transfer completed successfully") {
-					found = true
-					break
-				}
-			}
-			r.True(found, "expected transfer success log for input type %s", tc.inputType)
+			// Exit status + target CTF verification below are sufficient.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cli/cmd/type_casing_test.go` around lines 291 - 300, Remove the brittle
substring-based success assertion that searches transferEntries for "transfer
completed successfully": delete or replace the loop over transferEntries (the
transferEntries, err := transferLogs.List() call and the subsequent for-loop
that sets found) and the r.True(found, "expected transfer success log for input
type %s", tc.inputType) assertion; instead rely on the existing exit status and
the target CTF assertions already present in the test to validate success. Keep
transferLogs.List() only if its results are used elsewhere; otherwise remove the
unused variable to avoid dead code.

bindings/go/helm/spec/input/v1/spec.go (1)

16-17: Enum ordering inconsistent with the new primary type.

Since Type is now "Helm" (primary) with "helm" preserved only as the legacy alias, consider flipping the enum order to match bindings/go/helm/spec/access/v1/helm.go (which uses Helm/v1,helm/v1 and Helm,helm). Leading with the primary form makes generated JSON schemas advertise the canonical identifier first.

Proposed tweak

-	// +ocm:jsonschema-gen:enum=helm/v1,Helm/v1
-	// +ocm:jsonschema-gen:enum:deprecated=helm,Helm
+	// +ocm:jsonschema-gen:enum=Helm/v1,helm/v1
+	// +ocm:jsonschema-gen:enum:deprecated=Helm,helm

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/helm/spec/input/v1/spec.go` around lines 16 - 17, The enum
annotation ordering is reversed: update the schema tags in
bindings/go/helm/spec/input/v1/spec.go so the canonical primary identifiers come
first (match bindings/go/helm/spec/access/v1/helm.go); change the first enum
line to use Helm/v1,helm/v1 and the second to Helm,helm (i.e., swap the current
“helm/v1,Helm/v1” and “helm,Helm” entries) so the Type enum advertises the
canonical "Helm" forms first.