bindings/go/credentials/plugins.go (1)

53-55: Consider using errors.New for sentinel errors and a more specific message.

For sentinel errors that don't require formatting and are compared using errors.Is(), errors.New is more idiomatic. Additionally, the error message could be more specific to indicate it's a repository plugin.

♻️ Suggested improvement

-// ErrNoRepositoryPluginFound is returned when no repository plugin can be found for a given typed object.
-// TODO(`@frewilhelm`): Discuss if we want to introduce another API instead, e.g. IsRegistered(typed runtime.Typed)
-var ErrNoRepositoryPluginFound = fmt.Errorf("plugin not found")
+// ErrNoRepositoryPluginFound is returned when no repository plugin can be found for a given typed object.
+// TODO(`@frewilhelm`): Discuss if we want to introduce another API instead, e.g. IsRegistered(typed runtime.Typed)
+var ErrNoRepositoryPluginFound = errors.New("no repository plugin found")

This would also allow removing the "fmt" import (line 5) since it's only used for this error declaration.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/credentials/plugins.go` around lines 53 - 55, Replace the
sentinel error declaration ErrNoRepositoryPluginFound to use errors.New with a
more specific message (e.g., "repository plugin not found") instead of
fmt.Errorf, update any imports to remove "fmt" and add "errors" if necessary,
and keep the existing variable name so callers using
errors.Is(ErrNoRepositoryPluginFound, ...) continue to work.

bindings/go/credentials/resolve_indirect.go (1)

37-39: Consider including the original error for consistency.

When anyErr is ErrNoRepositoryPluginFound, only anyErr is joined with ErrNoIndirectCredentials, but the original err from line 26 is discarded. For other error cases (line 41), both errors are joined. Consider whether the original error should also be included for debugging/traceability:

return nil, errors.Join(err, anyErr, ErrNoIndirectCredentials)

If this is intentional (e.g., to provide a cleaner error when both calls fail with the same "not found" reason), the current approach is fine—just wanted to flag the inconsistency.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/credentials/resolve_indirect.go` around lines 37 - 39, The branch
that handles errors.Is(anyErr, ErrNoRepositoryPluginFound) currently returns
errors.Join(anyErr, ErrNoIndirectCredentials) and drops the original err; update
that return to include the original err as well (i.e., return errors.Join(err,
anyErr, ErrNoIndirectCredentials)) so the stack/traceability is consistent with
the other branch that joins both err and anyErr; locate the conditional using
anyErr, ErrNoRepositoryPluginFound, ErrNoIndirectCredentials in
resolve_indirect.go and modify the return accordingly.