chore: change environment name to "release" by morri-son · Pull Request #1949 · open-component-model/open-component-model

morri-son · 2026-03-11T09:53:26Z

On-behalf-of: Gerald Morrison (SAP) gerald.morrison@sap.com

What this PR does / why we need it

Change the GH environment name to "release" for all release workflows.

Summary by CodeRabbit

Chores
- Updated release gating to target the "release" environment instead of the prior environment name.
- Adjusted attestations/verification gating and removed an unnecessary wait/comment.
- Updated release process documentation to reflect the environment name change.

On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

coderabbitai · 2026-03-11T09:53:51Z

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 46a75d09-4912-4a45-b2b5-ffc7e68aee17

📥 Commits

Reviewing files that changed from the base of the PR and between b391c3e and d046e04.

📒 Files selected for processing (1)

RELEASE_PROCESS.md

📝 Walkthrough

Walkthrough

Renames the Phase 2 environment gate from cli/release to release in the GitHub Actions workflow and updates the RELEASE_PROCESS.md text to reference the release environment instead of cli/release; removes an inline comment in the workflow. No logic or public APIs changed.

Changes

Cohort / File(s)	Summary
Workflow config `.github/workflows/cli-release.yml`	Renamed environment gate from `cli/release` to `release` in the environment declaration and in the `verify_attestations` job; removed an inline wait timer comment line.
Documentation / Release process `RELEASE_PROCESS.md`	Updated final-promotion wording to reference the `release` environment gate instead of `cli/release` in two places.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

size/xs, component/github-actions, docs

Suggested reviewers

frewilhelm
matthiasbruns
jakobmoellerdev

Poem

🐰 A hop and a nibble, a tidy small tweak,
cli/release renamed, now release we seek,
Gates align neatly, the steps all the same,
A rabbit's small cheer for the workflow's new name! 🥕✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: renaming the GitHub environment from 'cli/release' to 'release' across workflow and documentation files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/cli-release.yml (1)
181-194: ⚠️ Potential issue | 🔴 Critical

Verify the release environment is configured and update RELEASE_PROCESS.md.

Line 194 changes the environment gate from cli/release to release, but RELEASE_PROCESS.md still documents approval of the cli/release environment gate. This mismatch will cause release managers to approve the wrong environment, silently blocking Phase 2 (verify_attestations, promote_final, release_final).

Before merging:

Confirm the release environment exists in GitHub Settings with the same protection rules (required reviewers, wait timer, branch policy) as the previous cli/release gate.

Update RELEASE_PROCESS.md to instruct approval of the release environment instead of cli/release.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/cli-release.yml around lines 181 - 194, The workflow
changed the environment gate from "cli/release" to "release" for the
verify_attestations job (job id verify_attestations, environment: name:
release), but RELEASE_PROCESS.md still references "cli/release"; update
RELEASE_PROCESS.md to instruct approvers to approve the "release" environment
and confirm in GitHub Settings that the "release" environment exists with the
same protection rules (required reviewers, wait timer, branch policy) previously
applied to "cli/release" before merging so Phase 2 jobs (verify_attestations,
promote_final, release_final) are not blocked.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/cli-release.yml:
- Around line 181-194: The workflow changed the environment gate from
"cli/release" to "release" for the verify_attestations job (job id
verify_attestations, environment: name: release), but RELEASE_PROCESS.md still
references "cli/release"; update RELEASE_PROCESS.md to instruct approvers to
approve the "release" environment and confirm in GitHub Settings that the
"release" environment exists with the same protection rules (required reviewers,
wait timer, branch policy) previously applied to "cli/release" before merging so
Phase 2 jobs (verify_attestations, promote_final, release_final) are not
blocked.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9bccfc00-746c-497f-ab8d-2415f4b39d42

📥 Commits

Reviewing files that changed from the base of the PR and between 6205a8a and b391c3e.

📒 Files selected for processing (1)

.github/workflows/cli-release.yml

frewilhelm

Can we adjust the release process document as well (#1949 (review))

On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com>  #### What this PR does / why we need it Change the GH environment name to "release" for all release workflows.  ## Summary by CodeRabbit * **Chores** * Updated CI/CD workflow configuration to refine environment gating for release processes and removed redundant documentation.  Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com> Co-authored-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com>  #### What this PR does / why we need it Change the GH environment name to "release" for all release workflows.  ## Summary by CodeRabbit * **Chores** * Updated CI/CD workflow configuration to refine environment gating for release processes and removed redundant documentation.  Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com> Co-authored-by: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

change environment name to "release"

b391c3e

On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

morri-son requested a review from a team as a code owner March 11, 2026 09:53

morri-son added the kind/chore chore, maintenance, etc. label Mar 11, 2026

github-actions Bot added component/github-actions Changes on GitHub Actions or within `.github/` directory size/xs Extra small labels Mar 11, 2026

morri-son mentioned this pull request Mar 11, 2026

chore: Workflow for controller release #1900

Merged

coderabbitai Bot reviewed Mar 11, 2026

View reviewed changes

morri-son enabled auto-merge (squash) March 11, 2026 10:13

matthiasbruns previously approved these changes Mar 11, 2026

View reviewed changes

frewilhelm reviewed Mar 11, 2026

View reviewed changes

Skarlso previously approved these changes Mar 11, 2026

View reviewed changes

piotrjanik previously approved these changes Mar 11, 2026

View reviewed changes

correct environment name

bce395d

On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

morri-son dismissed stale reviews from piotrjanik, Skarlso, and matthiasbruns via bce395d March 11, 2026 13:11

frewilhelm approved these changes Mar 11, 2026

View reviewed changes

Merge branch 'main' into change-GH-environment

d046e04

frewilhelm requested review from Skarlso, matthiasbruns and piotrjanik March 11, 2026 13:11

fabianburth approved these changes Mar 11, 2026

View reviewed changes

morri-son merged commit 0f60b61 into open-component-model:main Mar 11, 2026
21 checks passed

coderabbitai Bot mentioned this pull request Mar 30, 2026

chore: remove redundant environment and add artifact metadata permissions #2119

Merged

1 task

morri-son deleted the change-GH-environment branch April 23, 2026 12:45

This was referenced May 29, 2026

chore: use github environments #2682

Merged

chore: use correct gh environment #2684

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: change environment name to "release"#1949

chore: change environment name to "release"#1949
morri-son merged 3 commits into
open-component-model:mainfrom
morri-son:change-GH-environment

morri-son commented Mar 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 11, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

frewilhelm left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

morri-son commented Mar 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

frewilhelm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

morri-son commented Mar 11, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 11, 2026 •

edited

Loading