chore: use ${{ github.repository_owner }} as repo for image pulls by morri-son · Pull Request #1925 · open-component-model/open-component-model

morri-son · 2026-03-09T08:19:36Z

On-behalf-of: Gerald Morrison (SAP) gerald.morrison@sap.com

What this PR does / why we need it

Instead of hard-coding open-component-model org, ${{ github.repository_owner }} should be used to enable testing on forks. The PR also changes the default tag for latest pushes to main to 0.0.0-main.

Summary by CodeRabbit

Chores
- Updated CI/CD workflow configurations to use dynamic repository owner values for image references.
- Revised default container image tags used by workflows, changing resolved defaults when inputs are not provided.
- Adjusted several workflow environment defaults to reflect the new image naming scheme and tag format.

…w 0.0.0-main tag as default On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

coderabbitai · 2026-03-09T08:20:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 41576e7c-8890-486d-be3f-cc2270cb070c

📥 Commits

Reviewing files that changed from the base of the PR and between 8f5d51b and 257862d.

📒 Files selected for processing (1)

.github/workflows/conformance.yml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/conformance.yml

📝 Walkthrough

Walkthrough

Three GitHub Actions workflows were modified to change hardcoded GHCR image references to use the repository owner variable and to adjust default image tags used by the conformance workflow.

Changes

Cohort / File(s)	Summary
Workflow: CLI image `.github/workflows/cli.yml`	Replaced hardcoded CLI image `ghcr.io/open-component-model/cli:tag@digest` with `ghcr.io/${{ github.repository_owner }}/cli:tag@digest` (owner made dynamic).
Workflow: Conformance defaults `.github/workflows/conformance.yml`	Updated default environment image values: `ghcr.io/open-component-model/cli:main` → `ghcr.io/open-component-model/cli:0.0.0-main` and `ghcr.io/open-component-model/kubernetes/controller/chart:0.0.0-c837a09` → `ghcr.io/open-component-model/kubernetes/controller/chart:0.0.0-main`.
Workflow: Toolkit image `.github/workflows/kubernetes-controller.yml`	Changed toolkit/chart image owner to use `ghcr.io/${{ github.repository_owner }}/kubernetes/controller/chart:...` instead of fixed `open-component-model`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through CI with nimble feet,

Swapped hardcoded paths for ones that greet,
Now images follow where owners roam,
CI sings softly — this registry’s home.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: replacing hard-coded organization references with github.repository_owner variable across three workflow files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/conformance.yml:
- Line 38: The default TOOLKIT_IMAGE value uses the tag '0.0.0-main' which isn't
published by the controller publisher (kubernetes-controller.yml publishes tags
like '0.0.0-${short_sha}'), causing standalone conformance runs to fail; update
the default TOOLKIT_IMAGE in conformance.yml to use the same short-SHA based
pattern (e.g., '0.0.0-${short_sha}' or a stable published tag) or change the
publisher in kubernetes-controller.yml to also publish '0.0.0-main' so both
naming schemes exist—adjust the TOOLKIT_IMAGE default or the publish step so
TOOLKIT_IMAGE, kubernetes-controller.yml, and conformance.yml agree on the tag
format.

In @.github/workflows/kubernetes-controller.yml:
- Line 173: The publish destination is hardcoded to ghcr.io/open-component-model
in the publish_latest job while toolkit_image uses ghcr.io/${{
github.repository_owner }}, causing mismatched owners; update the publish_latest
steps that build/push the controller image and chart (the steps producing the
chart and image artifacts and their push commands/arguments) to use ghcr.io/${{
github.repository_owner }} (or a reusable variable like repo_owner) instead of
ghcr.io/open-component-model so both the publish job and the toolkit_image
reference the same owner-aware registry string and forks publish/pull from the
same repository.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 53782d4e-128a-47f4-9ca0-a8e0d111872c

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea6370 and 8f5d51b.

📒 Files selected for processing (3)

.github/workflows/cli.yml
.github/workflows/conformance.yml
.github/workflows/kubernetes-controller.yml

jakobmoellerdev · 2026-03-09T12:04:21Z

@morri-son do you wanna still incorporate the comments?

…en-component-model#1925) On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com>  #### What this PR does / why we need it Instead of hard-coding `open-component-model` org, ${{ github.repository_owner }} should be used to enable testing on forks. The PR also changes the default tag for latest pushes to main to `0.0.0-main`.  ## Summary by CodeRabbit * **Chores** * Updated CI/CD workflow configurations with dynamic repository references and revised version tags.  Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com> Co-authored-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

…en-component-model#1925) On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com>  #### What this PR does / why we need it Instead of hard-coding `open-component-model` org, ${{ github.repository_owner }} should be used to enable testing on forks. The PR also changes the default tag for latest pushes to main to `0.0.0-main`.  ## Summary by CodeRabbit * **Chores** * Updated CI/CD workflow configurations with dynamic repository references and revised version tags.  Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com> Co-authored-by: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

use ${{ github.repository_owner }} as repo for image pulls and use ne…

3f0d759

…w 0.0.0-main tag as default On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

morri-son requested a review from a team as a code owner March 9, 2026 08:19

morri-son added the kind/chore chore, maintenance, etc. label Mar 9, 2026

Merge branch 'main' into correct-conformance-defaults

8f5d51b

github-actions Bot added the component/github-actions Changes on GitHub Actions or within `.github/` directory label Mar 9, 2026

github-actions Bot added the size/xs Extra small label Mar 9, 2026

coderabbitai Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread .github/workflows/conformance.yml

Comment thread .github/workflows/kubernetes-controller.yml

frewilhelm approved these changes Mar 9, 2026

View reviewed changes

jakobmoellerdev approved these changes Mar 9, 2026

View reviewed changes

matthiasbruns approved these changes Mar 9, 2026

View reviewed changes

frewilhelm enabled auto-merge (squash) March 9, 2026 09:52

frewilhelm disabled auto-merge March 9, 2026 09:52

jakobmoellerdev enabled auto-merge (squash) March 9, 2026 10:40

Merge branch 'main' into correct-conformance-defaults

257862d

Merge branch 'main' into correct-conformance-defaults

6569f30

jakobmoellerdev merged commit f2af100 into open-component-model:main Mar 9, 2026
20 checks passed

coderabbitai Bot mentioned this pull request Mar 17, 2026

chore: add conformance to PRs using uploaded artifacts #2005

Merged

morri-son deleted the correct-conformance-defaults branch April 23, 2026 12:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: use ${{ github.repository_owner }} as repo for image pulls#1925

chore: use ${{ github.repository_owner }} as repo for image pulls#1925
jakobmoellerdev merged 4 commits into
open-component-model:mainfrom
morri-son:correct-conformance-defaults

morri-son commented Mar 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 9, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

jakobmoellerdev commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

morri-son commented Mar 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jakobmoellerdev commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

morri-son commented Mar 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 9, 2026 •

edited

Loading