fix: testdata location in cli tests by matthiasbruns · Pull Request #1921 · open-component-model/open-component-model

matthiasbruns · 2026-03-08T11:57:13Z

What this PR does / why we need it

This PR fixes the testdata location in cli tests after it has been moved in the helm module

Which issue(s) this PR fixes

Contributes: open-component-model/ocm-project#883

Summary by CodeRabbit

Tests
- Adjusted Helm chart test data path used by integration tests to match the restructured test directory layout.
Chores
- Bumped a Helm-related dependency used by the CLI and integration test modules to a newer upstream revision.

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

coderabbitai · 2026-03-08T11:57:30Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4d8ab656-f0b4-40a0-b6a6-9f4bbdc521ab

📥 Commits

Reviewing files that changed from the base of the PR and between bd61318 and aa2e5ca.

⛔ Files ignored due to path filters (2)

cli/go.sum is excluded by !**/*.sum
cli/integration/go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

cli/go.mod
cli/integration/go.mod

📝 Walkthrough

Walkthrough

Updated a Helm chart test path in an integration test and bumped the ocm helm binding dependency versions in two go.mod files. No functional logic or exported APIs were changed.

Changes

Cohort / File(s)	Summary
Helm Transformer Test Path Update `cli/integration/download_resource_integration_test.go`	Adjusted Helm chart testdata path in Test_Integration_HelmTransformer: changed `bindings/go/helm/input/testdata/provenance/mychart-0.1.0.tgz` → `bindings/go/helm/testdata/provenance/mychart-0.1.0.tgz`.
CLI module dependency bump `cli/go.mod`	Updated `ocm.software/open-component-model/bindings/go/helm` pseudo-version from `v0.0.0-20260304112256-b1226ed291db` → `v0.0.0-20260308114111-a3c1debc152d`.
Integration module dependency bump (indirect) `cli/integration/go.mod`	Bumped indirect dependency `ocm.software/open-component-model/bindings/go/helm` to `v0.0.0-20260308114111-a3c1debc152d` (previously `v0.0.0-20260304112256-b1226ed291db`).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tiny hop, a path made right,
Charts aligned beneath moonlight,
Versions nudged, nothing to fear,
Tests will hum — the meadow's clear. 🌙🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adjusting testdata location in CLI tests following a directory move in the helm module.
Linked Issues check	✅ Passed	The PR addresses integration test updates required by issue `#883`, adjusting test data paths after the helm module testdata restructuring to ensure tests work with the new structure.
Out of Scope Changes check	✅ Passed	All changes (test data path adjustment and dependency version bumps) are directly related to fixing test failures caused by the helm module testdata directory move.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

#### What this PR does / why we need it This PR fixes the `testdata` location in cli tests after it has been moved in the helm module #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#883  ## Summary by CodeRabbit * **Tests** * Adjusted Helm chart test data path used by integration tests to match the restructured test directory layout. * **Chores** * Bumped a Helm-related dependency used by the CLI and integration test modules to a newer upstream revision.  --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

#### What this PR does / why we need it This PR fixes the `testdata` location in cli tests after it has been moved in the helm module #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#883  ## Summary by CodeRabbit * **Tests** * Adjusted Helm chart test data path used by integration tests to match the restructured test directory layout. * **Chores** * Bumped a Helm-related dependency used by the CLI and integration test modules to a newer upstream revision.  --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

fix: testdata location in cli tests

bd61318

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

github-actions Bot added the kind/bugfix Bug label Mar 8, 2026

matthiasbruns marked this pull request as ready for review March 8, 2026 11:57

matthiasbruns requested a review from a team as a code owner March 8, 2026 11:57

github-actions Bot added the size/xs Extra small label Mar 8, 2026

fix: tests

aa2e5ca

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

github-actions Bot added the size/s Small label Mar 8, 2026

matthiasbruns enabled auto-merge (squash) March 8, 2026 12:36

Skarlso approved these changes Mar 8, 2026

View reviewed changes

jakobmoellerdev approved these changes Mar 8, 2026

View reviewed changes

matthiasbruns merged commit 69440bd into open-component-model:main Mar 8, 2026
25 checks passed

coderabbitai Bot mentioned this pull request Mar 9, 2026

feat(883): helm transfer cli #1846

Merged

1 task

matthiasbruns linked an issue Mar 10, 2026 that may be closed by this pull request

Implement helm chart download transformer open-component-model/ocm-project#883

Closed

8 tasks

coderabbitai Bot mentioned this pull request Apr 16, 2026

feat: 911 helm resource repo #2130

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: testdata location in cli tests#1921

fix: testdata location in cli tests#1921
matthiasbruns merged 2 commits into
open-component-model:mainfrom
matthiasbruns:fix/testdata_move_cli

matthiasbruns commented Mar 8, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 8, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

matthiasbruns commented Mar 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Which issue(s) this PR fixes

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

matthiasbruns commented Mar 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 8, 2026 •

edited

Loading