Skip to content

fix(1776): ctf detection on windows absolute paths#1792

Merged
matthiasbruns merged 15 commits into
open-component-model:mainfrom
matthiasbruns:fix1776_windows_paths_detected_as_urls
Mar 3, 2026
Merged

fix(1776): ctf detection on windows absolute paths#1792
matthiasbruns merged 15 commits into
open-component-model:mainfrom
matthiasbruns:fix1776_windows_paths_detected_as_urls

Conversation

@matthiasbruns

@matthiasbruns matthiasbruns commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

This PR fixed a problem in repository type detection for windows absolute paths.
In compref.go, --repository was detected as *ociv1.Repository which should actually be detected as ctfv1.Repository.

Unit tests have been added, but I will test this on a windows vm to ensure, that this fixes the issue

Which issue(s) this PR fixes

Fixes: #1776

@matthiasbruns matthiasbruns force-pushed the fix1776_windows_paths_detected_as_urls branch from 58165ee to fecd23f Compare February 17, 2026 14:26
@matthiasbruns matthiasbruns marked this pull request as ready for review February 18, 2026 14:52
@matthiasbruns matthiasbruns requested a review from a team as a code owner February 18, 2026 14:52
Skarlso
Skarlso previously approved these changes Feb 18, 2026
View reviewed changes

@Skarlso Skarlso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. :D

@matthiasbruns

matthiasbruns commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

it works

C:\Users\win10\Downloads>ocm.exe add component-version --constructor C:\Users\win10\Downloads\backend-constructor.yaml --repository C:\Users\win10\Downloads\ctf
time=2026-02-19T14:12:26.018Z level=WARN msg="could not get credential consumer identity for component version repository" repository=C:\Users\win10\Downloads\ctf error="failed to get component version repository: cannot resolve consumer identity for ctf: credentials not supported"
 COMPONENT                      │ VERSION │ PROVIDER
────────────────────────────────┼─────────┼──────────────
 ocm.software/tutorials/backend │ 1.0.0   │ ocm.software

jakobmoellerdev
jakobmoellerdev reviewed Feb 19, 2026
View reviewed changes
Comment thread cli/internal/reference/compref/compref.go
@github-actions github-actions Bot added component/github-actions Changes on GitHub Actions or within `.github/` directory size/m Medium labels Feb 19, 2026
@matthiasbruns matthiasbruns force-pushed the fix1776_windows_paths_detected_as_urls branch 4 times, most recently from e4f1bbf to d6f8eb2 Compare February 20, 2026 07:02
@matthiasbruns
fix(1776): ctf detection on windows absolute paths
e52616f 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: add matrix os tests
1787ed5 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: os aware path checking
9393069 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: windows testing
c194196 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: rollback to os-independant checks
2958123 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: add windows issue ticket
24aaa8a 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: add docs windows support
7dfd2df 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the fix1776_windows_paths_detected_as_urls branch from 5364df6 to 7dfd2df Compare February 20, 2026 09:00
jakobmoellerdev
jakobmoellerdev reviewed Feb 20, 2026
View reviewed changes
Comment thread cli/docs/reference/windows-support.md Outdated
@matthiasbruns matthiasbruns mentioned this pull request Feb 20, 2026
Merged
@matthiasbruns
feat: remove windows hint (moved to ocm-website)
66230d2 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
matthiasbruns added a commit to open-component-model/ocm-website that referenced this pull request Feb 20, 2026
@matthiasbruns @morri-son
feat: add windows hint (#718)
1b6d8f5 
#### What this PR does / why we need it
This PR is a result of the discussions on
open-component-model/open-component-model#1792

We want to notify windows users installing ocm cli, that we provide a
best-effort support at best.

#### Which issue(s) this PR fixes
Contributes:
open-component-model/open-component-model#1776

---------

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Signed-off-by: Matthias Bruns <github@matthiasbruns.com>
Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com>
ocmbot Bot pushed a commit to open-component-model/ocm-website that referenced this pull request Feb 20, 2026
@github-actions
feat: add windows hint (#718)
55cc6df 
#### What this PR does / why we need it
This PR is a result of the discussions on
open-component-model/open-component-model#1792

We want to notify windows users installing ocm cli, that we provide a
best-effort support at best.

#### Which issue(s) this PR fixes
Contributes:
open-component-model/open-component-model#1776

---------

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Signed-off-by: Matthias Bruns <github@matthiasbruns.com>
Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com> 1b6d8f5
@matthiasbruns matthiasbruns enabled auto-merge (squash) February 20, 2026 15:31
jakobmoellerdev
jakobmoellerdev reviewed Feb 20, 2026
View reviewed changes
Comment thread cli/internal/reference/compref/compref.go
fabianburth
fabianburth reviewed Feb 24, 2026
View reviewed changes
Comment thread cli/internal/reference/compref/compref.go
Comment thread cli/internal/reference/compref/compref.go
Comment thread cli/internal/reference/compref/compref.go
matthiasbruns and others added 2 commits February 25, 2026 09:11
@matthiasbruns
Merge branch 'main' into fix1776_windows_paths_detected_as_urls
a62c834
@matthiasbruns
chore: update tests
046fc6e 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns merged commit 13b0f76 into open-component-model:main Mar 3, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianburth fabianburth fabianburth approved these changes

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

@Skarlso Skarlso Awaiting requested review from Skarlso

Assignees

No one assigned

Labels

component/github-actions Changes on GitHub Actions or within `.github/` directory kind/bugfix Bug size/m Medium size/s Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

failed to parse repository URI on Windows

4 participants

@matthiasbruns @Skarlso @fabianburth @jakobmoellerdev