Skip to content

fix: update the configuration to 0.0.10 and fix the resolver prepending a catch-all incorrectly#1773

Merged
Skarlso merged 5 commits into
open-component-model:mainfrom
Skarlso:fix-the-resolver
Feb 13, 2026
Merged

fix: update the configuration to 0.0.10 and fix the resolver prepending a catch-all incorrectly#1773
Skarlso merged 5 commits into
open-component-model:mainfrom
Skarlso:fix-the-resolver

Conversation

@Skarlso

@Skarlso Skarlso commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

During the testing of the tutorial PR here we discovered two things:

  • the configuration module was wastly outdated and contained important fixes and switched to v1 from v1alpha1 that weren't released or updated since 2 months ago
  • after the resolver refactor, we left in a tiny piece of fall-back logic in the CLI resolver construction in which a catch-all * was prepended to the resolver pattern if no patterns were given. This meant that no resolvers were ever used that were configured because the catch-all overwrote everything.

Which issue(s) this PR fixes

@Skarlso Skarlso requested a review from a team as a code owner February 13, 2026 09:28
@Skarlso Skarlso mentioned this pull request Feb 13, 2026
Merged
@Skarlso

Skarlso commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

I will try to add an integration test update for this, because technically, they should have failed but they didn't this means that there was insufficient coverage somewhere.

@matthiasbruns matthiasbruns mentioned this pull request Feb 13, 2026
Closed
7 tasks
matthiasbruns
matthiasbruns reviewed Feb 13, 2026
View reviewed changes
Comment thread cli/internal/repository/ocm/compatibility.go
piotrjanik
piotrjanik previously approved these changes Feb 13, 2026
View reviewed changes
@Skarlso

Skarlso commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

Manually going through the multi repo scenario:

time=2026-02-13T10:17:55.689+01:00 level=DEBUG msg="component construction completed successfully"
time=2026-02-13T10:17:55.689+01:00 level=DEBUG msg="locking graph for traversal" roots="[name=ocm.software/tutorials/app,version=1.0.0]"
 COMPONENT                       │ VERSION │ PROVIDER     
─────────────────────────────────┼─────────┼──────────────
 ocm.software/tutorials/app      │ 1.0.0   │ ocm.software 
 ocm.software/tutorials/backend  │ 1.0.0   │              
 ocm.software/tutorials/frontend │ 1.0.0   │              
time=2026-02-13T10:17:55.689+01:00 level=DEBUG msg="unlocking graph after traversal"

Trying to still write a good enough test for this. :)

@github-actions github-actions Bot added the size/m Medium label Feb 13, 2026
@Skarlso

Skarlso commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

Pushed a test that I think is okay, gonna try and run it without the changes too to see if it fails.

@Skarlso

Skarlso commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

Ah, I see the go mod bump was merged. :D

Skarlso and others added 3 commits February 13, 2026 11:44
@Skarlso @matthiasbruns
fix: update the configuration to 0.0.10 and fix the resolver prependi…
8b35b25 
…ng a catch-all incorrectly

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

# Conflicts:
#	cli/go.mod
#	cli/go.sum
#	cli/integration/go.mod
#	cli/integration/go.sum
@Skarlso @matthiasbruns
this should effectively test the resolvers
9adf59d 
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@matthiasbruns
chore: rebase
dcc3925 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns

matthiasbruns commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

@Skarlso I updated the tests to ensure that the components are correctly loaded

@matthiasbruns
feat: test for components in resolvers
925e823 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@Skarlso

Skarlso commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

Looks like a fluke

@Skarlso

Skarlso commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

@matthiasbruns thanks for the test addition.

@Skarlso Skarlso requested a review from piotrjanik February 13, 2026 13:04
@Skarlso Skarlso merged commit a99b1bb into open-component-model:main Feb 13, 2026
20 checks passed
@Skarlso Skarlso deleted the fix-the-resolver branch February 13, 2026 13:05
morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Feb 16, 2026
@Skarlso @matthiasbruns @morrison-sap
fix: update the configuration to 0.0.10 and fix the resolver prependi…
0714ea0 
…ng a catch-all incorrectly (open-component-model#1773)

Co-authored-by: Matthias Bruns <git@matthiasbruns.com>
morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Feb 18, 2026
@Skarlso @matthiasbruns @morrison-sap
fix: update the configuration to 0.0.10 and fix the resolver prependi…
8cade79 
…ng a catch-all incorrectly (open-component-model#1773)

Co-authored-by: Matthias Bruns <git@matthiasbruns.com>
Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piotrjanik piotrjanik piotrjanik approved these changes

@matthiasbruns matthiasbruns matthiasbruns approved these changes

Assignees

No one assigned

Labels

kind/bugfix Bug size/m Medium size/s Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Skarlso @matthiasbruns @piotrjanik