Skip to content

feat: oci artifact uploader spec#1769

Merged
matthiasbruns merged 59 commits into
open-component-model:mainfrom
matthiasbruns:feat/oci-artifact-uploader_spec
Feb 13, 2026
Merged

feat: oci artifact uploader spec#1769
matthiasbruns merged 59 commits into
open-component-model:mainfrom
matthiasbruns:feat/oci-artifact-uploader_spec

Conversation

@matthiasbruns

@matthiasbruns matthiasbruns commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

This PR adds AddOCIArtifact spec to oci.

type AddOCIArtifactSpec struct {
	// Resource is the resource descriptor to add.
	// If the Resource contains an access specification, it may be used
	// by the underlying implementation to derive metadata to avoid additional compute
	// (such as digest information) or to steer implementation (such as a reference name)
	Resource *v2.Resource `json:"resource"`
	// File is the access specification to the file that should be added
	File v1alpha1.File `json:"file"`
}

We expect a file access and a resource descriptor as input for the add transformation. The file will be uploaded to the OCIRepository based on the Resource input.

type AddOCIArtifactOutput struct {
	// Resource is the updated resource descriptor with complete oci image reference
	Resource *v2.Resource `json:"resource"`
}

The output of the transformation is the updated Resource pointing to the newly uploaded oci image.

Which issue(s) this PR fixes

Contributes: open-component-model/ocm-project#875

Part of:

@github-actions github-actions Bot added the size/l Large label Feb 12, 2026
@matthiasbruns matthiasbruns mentioned this pull request Feb 12, 2026
Merged
@matthiasbruns matthiasbruns changed the title Feat/oci artifact uploader spec feat: oci artifact uploader spec Feb 12, 2026
@github-actions github-actions Bot added the kind/feature new feature, enhancement, improvement, extension label Feb 12, 2026
@matthiasbruns
feat: oci artifact bindings
fd7c653 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

# Conflicts:
#	bindings/go/oci/spec/transformation/v1alpha1/scheme.go
#	bindings/go/oci/spec/transformation/v1alpha1/zz_generated.deepcopy.go
#	bindings/go/oci/spec/transformation/v1alpha1/zz_generated.ocm_jsonschema.go
#	bindings/go/oci/spec/transformation/v1alpha1/zz_generated.ocm_type.go
#	bindings/go/oci/transformer/get_oci_artifact.go
#	bindings/go/oci/transformer/get_oci_artifact_test.go
@matthiasbruns
feat: remove repository from oci and component fields
71d82fe 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
fix: json gen
a3b8500 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: remove transformer spec aftre wr
fec5474 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
fix: build
ebbc0ba 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
fix: tests
5fd7491 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
fix: lint
a093938 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: clean up schemas
91ff3e6 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: cleanup based on pr review
4f9b46f 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
fix: v1alpha1.GetOCIArtifact parsing
0fd8477 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: rename GetOCIArtifactType
9fc4ec6 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
fix: tests
7490e0f 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: add repo abstraction for testing
52d545b 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: use new ResourceRepo abstraction
76b3257 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
fix: generated code
4e4a59d 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: register in cli
188a90f 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: pin local oci
5d8557e 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: start integration testing transfer artifacts
2e34ab2 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: prepare another refactoring 🥲
9556f2c 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

# Conflicts:
#	bindings/go/plugin/manager/registries/resource/contract.go
#	bindings/go/plugin/manager/registries/resource/resource_converter.go
@matthiasbruns
feat: make ResourceRegistry a ResourceRepository itself
11c657b 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: add todos
84e9b78 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
chore: clean up after rebase
544dbd5 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

# Conflicts:
#	bindings/go/oci/integration/go.sum
#	cli/go.sum
#	cli/integration/go.mod
#	cli/integration/go.sum
@matthiasbruns
feat: handle oci download & upload and add copymode
47643ac 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
fix: schema registration
f879265 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: it works 🚀
951e89d 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: map referenceName
6647f1f 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
matthiasbruns and others added 12 commits February 12, 2026 16:41
@matthiasbruns
feat: use looseref
9132697 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
Apply suggestions from code review
3fdc3a1 
Signed-off-by: Matthias Bruns <github@matthiasbruns.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@fabianburth @matthiasbruns
fix: clean up `--copy-local-resources and GetReferenceName
586d209 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@fabianburth @matthiasbruns
fix: fix GetReferenceName
bac1db1 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@fabianburth @matthiasbruns
fix: update OCI image reference to use correct import
b017b68 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@fabianburth @matthiasbruns
fix: set correct access type in tgd generator
2df0e9e 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@fabianburth @matthiasbruns
feat: add reference name check to integration test
0a68754 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@fabianburth @matthiasbruns
add oci artifact transformer and transformation spec
a94a8c8 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@fabianburth @matthiasbruns
feat: implement cli command for uploading oci artifacts
f0d8df6 
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: add optional cel expressions
8be18b0 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: oci add spec
5241dbd 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns
feat: add integration tests
dc6c29b 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the feat/oci-artifact-uploader_spec branch from 8aa1bf3 to dc6c29b Compare February 12, 2026 15:41
@matthiasbruns matthiasbruns marked this pull request as ready for review February 12, 2026 15:41
@matthiasbruns matthiasbruns requested a review from a team as a code owner February 12, 2026 15:41
@matthiasbruns matthiasbruns mentioned this pull request Feb 12, 2026
Closed
7 tasks
Skarlso
Skarlso reviewed Feb 12, 2026
View reviewed changes

@Skarlso Skarlso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two things only actually.

Comment thread bindings/go/oci/spec/transformation/v1alpha1/add_oci_artifact.go Outdated
Comment thread bindings/go/oci/integration/integration_test.go
@matthiasbruns matthiasbruns force-pushed the feat/oci-artifact-uploader_spec branch from 2d9ae7b to 8af3ef4 Compare February 12, 2026 16:33
Skarlso
Skarlso previously approved these changes Feb 12, 2026
View reviewed changes

@Skarlso Skarlso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthiasbruns
chore: review
a22c992 
On-behalf-of: SAP <matthias.bruns@sap.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the feat/oci-artifact-uploader_spec branch from 8af3ef4 to a22c992 Compare February 12, 2026 16:36
@matthiasbruns matthiasbruns merged commit 79ff130 into open-component-model:main Feb 13, 2026
19 checks passed
morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Feb 16, 2026
@matthiasbruns @fabianburth @morrison-sap
feat: oci artifact uploader spec (open-component-model#1769)
135380b 
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it
This PR adds AddOCIArtifact spec to oci.

```go
type AddOCIArtifactSpec struct {
	// Resource is the resource descriptor to add.
	// If the Resource contains an access specification, it may be used
	// by the underlying implementation to derive metadata to avoid additional compute
	// (such as digest information) or to steer implementation (such as a reference name)
	Resource *v2.Resource `json:"resource"`
	// File is the access specification to the file that should be added
	File v1alpha1.File `json:"file"`
}
```
We expect a file access and a resource descriptor as input for the add
transformation. The file will be uploaded to the `OCIRepository` based
on the `Resource` input.

```go
type AddOCIArtifactOutput struct {
	// Resource is the updated resource descriptor with complete oci image reference
	Resource *v2.Resource `json:"resource"`
}
```
The output of the transformation is the updated `Resource` pointing to
the newly uploaded oci image.

#### Which issue(s) this PR fixes
Contributes:
open-component-model/ocm-project#875

Part of:
- open-component-model#1765

---------

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Signed-off-by: Matthias Bruns <github@matthiasbruns.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Co-authored-by: Fabian Burth <fabian.burth@sap.com>
@matthiasbruns matthiasbruns mentioned this pull request Feb 17, 2026
Closed
morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Feb 18, 2026
@matthiasbruns @fabianburth @morrison-sap
feat: oci artifact uploader spec (open-component-model#1769)
1aa3da4 
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it
This PR adds AddOCIArtifact spec to oci.

```go
type AddOCIArtifactSpec struct {
	// Resource is the resource descriptor to add.
	// If the Resource contains an access specification, it may be used
	// by the underlying implementation to derive metadata to avoid additional compute
	// (such as digest information) or to steer implementation (such as a reference name)
	Resource *v2.Resource `json:"resource"`
	// File is the access specification to the file that should be added
	File v1alpha1.File `json:"file"`
}
```
We expect a file access and a resource descriptor as input for the add
transformation. The file will be uploaded to the `OCIRepository` based
on the `Resource` input.

```go
type AddOCIArtifactOutput struct {
	// Resource is the updated resource descriptor with complete oci image reference
	Resource *v2.Resource `json:"resource"`
}
```
The output of the transformation is the updated `Resource` pointing to
the newly uploaded oci image.

#### Which issue(s) this PR fixes
Contributes:
open-component-model/ocm-project#875

Part of:
- open-component-model#1765

---------

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Signed-off-by: Matthias Bruns <github@matthiasbruns.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Co-authored-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Skarlso approved these changes

@piotrjanik piotrjanik piotrjanik approved these changes

Assignees

No one assigned

Labels

kind/feature new feature, enhancement, improvement, extension size/l Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthiasbruns @Skarlso @piotrjanik @fabianburth